[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #3214: Fix cast date type return wrong result

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #3214: Fix cast date type return wrong result
URL: https://github.com/apache/incubator-doris/pull/3214#discussion_r401677001
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java
 ##########
 @@ -320,6 +320,13 @@ protected void toThrift(TExprNode msg) {
     @Override
     protected Expr uncheckedCastTo(Type targetType) throws AnalysisException {
         if (targetType.isDateType()) {
+            if (targetType.equals(Type.DATE)) {
+                this.castToDate();                            
+            } else if (targetType.equals(Type.DATETIME)) {
+                this.type = Type.DATETIME;                            
 
 Review comment:
   Yes, is ok。And explicit type conver(cast expr) also go to this line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org