[GitHub] [pinot] mqliang commented on a change in pull request #7454: bit-sliced index for int, long, float, double, dictionarized SV columns

[GitBox <gi...@apache.org>]

mqliang commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r715216140



##########
File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/creator/BitSlicedIndexCreatorTest.java
##########
@@ -0,0 +1,487 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.segment.local.segment.index.creator;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Random;
+import java.util.function.DoubleSupplier;
+import java.util.function.LongSupplier;
+import java.util.stream.IntStream;
+import org.apache.commons.io.FileUtils;
+import org.apache.pinot.segment.local.segment.creator.impl.inv.BitSlicedRangeIndexCreator;
+import org.apache.pinot.segment.local.segment.index.readers.BitSlicedRangeIndexReader;
+import org.apache.pinot.segment.spi.ColumnMetadata;
+import org.apache.pinot.segment.spi.index.metadata.ColumnMetadataImpl;
+import org.apache.pinot.segment.spi.memory.PinotDataBuffer;
+import org.apache.pinot.spi.data.DimensionFieldSpec;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.roaringbitmap.buffer.ImmutableRoaringBitmap;
+import org.roaringbitmap.buffer.MutableRoaringBitmap;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION;

Review comment:
       we should avoid static import

##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##########
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.segment.local.segment.creator.impl.inv;
+
+import java.io.File;
+import java.io.IOException;
+import org.apache.pinot.segment.local.utils.FPOrdering;
+import org.apache.pinot.segment.spi.ColumnMetadata;
+import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.roaringbitmap.RangeBitmap;
+
+import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION;

Review comment:
       We should avoid static import IIRC

##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java
##########
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.segment.local.utils;
+
+public class FPOrdering {
+
+  private FPOrdering() {
+  }
+
+  /**
+   * Maps doubles to longs with the same total (unsigned) order
+   * NEGATIVE_INFINITY is considered less than or equal to all values.
+   * NaN and POSITIVE_INFINITY are considered greater than or equal to all values.
+   *
+   * @param value a double value
+   * @return an ordinal
+   */
+  public static long ordinalOf(double value) {
+    if (value == Double.NEGATIVE_INFINITY) {
+      return 0;
+    }
+    if (value == Double.POSITIVE_INFINITY || Double.isNaN(value)) {
+      return 0xFFFFFFFFFFFFFFFFL;
+    }
+    long bits = Double.doubleToLongBits(value);
+    // need negatives to come before positives
+    if ((bits & Long.MIN_VALUE) == Long.MIN_VALUE) {
+      // conflate 0/-0, or reverse order of negatives
+      bits = bits == Long.MIN_VALUE ? Long.MIN_VALUE : ~bits;

Review comment:
       question: do we actually distinguish -0 and +0 in pinot?

##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/FPOrdering.java
##########
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.segment.local.utils;
+
+public class FPOrdering {
+
+  private FPOrdering() {
+  }
+
+  /**
+   * Maps doubles to longs with the same total (unsigned) order
+   * NEGATIVE_INFINITY is considered less than or equal to all values.
+   * NaN and POSITIVE_INFINITY are considered greater than or equal to all values.
+   *
+   * @param value a double value
+   * @return an ordinal
+   */
+  public static long ordinalOf(double value) {
+    if (value == Double.NEGATIVE_INFINITY) {
+      return 0;
+    }
+    if (value == Double.POSITIVE_INFINITY || Double.isNaN(value)) {
+      return 0xFFFFFFFFFFFFFFFFL;
+    }
+    long bits = Double.doubleToLongBits(value);
+    // need negatives to come before positives
+    if ((bits & Long.MIN_VALUE) == Long.MIN_VALUE) {
+      // conflate 0/-0, or reverse order of negatives
+      bits = bits == Long.MIN_VALUE ? Long.MIN_VALUE : ~bits;
+    } else { // positives after negatives
+      bits ^= Long.MIN_VALUE;
+    }
+    return bits;
+  }
+
+  /**
+   * Maps doubles to ints with the same total (unsigned) order

Review comment:
       "Maps doubles to ints" --> "Maps floats to ints"

##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##########
@@ -0,0 +1,168 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.segment.local.segment.creator.impl.inv;
+
+import java.io.File;
+import java.io.IOException;
+import org.apache.pinot.segment.spi.ColumnMetadata;
+import org.apache.pinot.segment.spi.index.creator.CombinedInvertedIndexCreator;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.roaringbitmap.RangeBitmap;
+
+import static org.apache.pinot.segment.spi.V1Constants.Indexes.BITMAP_RANGE_INDEX_FILE_EXTENSION;
+import static org.apache.pinot.spi.data.FieldSpec.DataType.*;
+
+public class BitSlicedRangeIndexCreator implements CombinedInvertedIndexCreator {
+
+  public static final int RANGE_INDEX_VERSION = 2;
+
+  private final RangeBitmap.Appender _appender;
+  private final File _rangeIndexFile;
+  private final FieldSpec.DataType _valueType;
+  private final long _minValue;
+  private final double _scale;
+
+  public BitSlicedRangeIndexCreator(File indexDir, ColumnMetadata metadata) {
+    _appender = RangeBitmap.appender(maxValue(metadata));
+    _rangeIndexFile = new File(indexDir, metadata.getColumnName() + BITMAP_RANGE_INDEX_FILE_EXTENSION);
+    _valueType = metadata.getDataType();
+    _minValue = minValue(metadata);
+    _scale = scale(metadata);
+  }
+
+  @Override
+  public void add(int dictId) {
+    _appender.add(dictId - _minValue);
+  }
+
+  @Override
+  public void add(int[] dictIds, int length) {
+  }
+
+  @Override
+  public void add(long value) {
+    _appender.add(value - _minValue);
+  }
+
+  @Override
+  public void add(long[] values, int length) {
+  }
+
+  @Override
+  public void add(float value) {
+    if (!Float.isFinite(value)) {
+      // TODO this probably needs better handling, like using a 24th slice
+      //  for infinite values
+      _appender.add(0);
+    } else {
+      double d = value;
+      d -= Double.longBitsToDouble(_minValue);
+      d *= _scale;
+      _appender.add(Float.floatToIntBits((float) d));
+    }
+  }
+
+  @Override
+  public void add(float[] values, int length) {
+  }
+
+  @Override
+  public void add(double value) {
+    if (!Double.isFinite(value)) {
+      // TODO this probably needs better handling, like using a 57th slice
+      //  for infinite values
+      _appender.add(0L);
+    } else {
+      value -= Double.longBitsToDouble(_minValue);
+      value *= _scale;
+      _appender.add(Double.doubleToLongBits(value));
+    }
+  }
+
+  @Override
+  public void add(double[] values, int length) {
+  }
+
+  @Override
+  public void seal() throws IOException {
+    int headerSize = Integer.BYTES + Long.BYTES + (_valueType == FLOAT || _valueType == DOUBLE ? Double.BYTES : 0);
+    int serializedSize = _appender.serializedSizeInBytes();
+    try (MmapFileWriter writer = new MmapFileWriter(_rangeIndexFile, headerSize + serializedSize)) {
+      writer.write(buf -> {
+        buf.putInt(RANGE_INDEX_VERSION);
+        buf.putLong(_minValue);
+        if (_valueType == FLOAT || _valueType == DOUBLE) {
+          buf.putDouble(_scale);
+        }
+        _appender.serialize(buf);
+      });
+    }
+    _appender.clear();
+  }
+
+  @Override
+  public void close() throws IOException {
+
+  }
+
+  private static long maxValue(ColumnMetadata metadata) {
+    FieldSpec.DataType dataType = metadata.getDataType();
+    if (dataType == LONG || dataType == INT) {
+      Comparable<?> minValue = metadata.getMinValue();
+      Comparable<?> maxValue = metadata.getMaxValue();
+      if (minValue instanceof Number && maxValue instanceof Number) {
+        return ((Number) maxValue).longValue() - ((Number) minValue).longValue();
+      }
+    }
+    if (dataType == DOUBLE) {

Review comment:
       As `0xFFFFFFFFFFFFFFFFL`,`0xFFFFFFFFL`, and `0L` are also used in `FPOrdering`, declare them as `MAX_ORDINAL_DOUBLE`, `MAX_ORDINAL_FLOAT`, `MIN_ORDINAL_DOUBLE`, `MIN_ORDINAL_FLOAT` in `FPOrdering` and import here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org