You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2015/07/15 00:52:41 UTC

[GitHub] trafficserver pull request: [TS-3648] Desire support for client TL...

GitHub user ericcarlschwartz opened a pull request:

    https://github.com/apache/trafficserver/pull/252

    [TS-3648] Desire support for client TLS cipher in custom log format

    Took @acaciocenteno's original PR here and updated it a bit: https://github.com/apache/trafficserver/pull/122
    
    1) added docs and changed log tags to be more in line with ats conventions
    2) removed some accessor methods and reordered where log tags are set to happen at the same time @fpesce was already grabbing some SSL info
    3) made other changes suggested in the original PR

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ericcarlschwartz/trafficserver TS-3648

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #252
    
----
commit 40bd7d3a17751dae927671569deb6139ba91903a
Author: Acácio Centeno <ac...@gmail.com>
Date:   2014-09-25T16:23:31Z

    [TS-3648] Desire support for client TLS cipher in custom log format

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-3648] Desire support for client TL...

Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/252#issuecomment-129571297
  
    Looks good to me.   A straightforward reworking of acacio's original PR in the face of the other SSL logging changes that have been made.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-3648] Desire support for client TL...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---