You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/29 10:11:07 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5332: arch/Toolchain.defs: Simplify addition builtin library to EXTRA_LIBS

xiaoxiang781216 edited a comment on pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#issuecomment-1024881579


   > @xiaoxiang781216 I noticed that sama5d4-ek:ksh build failed. Could you confirm what is happening now?
   > 
   
   Because ARCHCPUFLAGS overwrite by board's Make.defs:
   https://github.com/apache/incubator-nuttx/blob/master/boards/arm/sama5/sama5d4-ek/scripts/Make.defs#L51
   so the flags used to find the library in Toolchain.defs is different from the compiling.
   Could you try https://github.com/apache/incubator-nuttx/pull/5371?
   Do you know why CI doesn't catch this error before merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org