How to submit/apply code changes

["Noel J. Bergman" <no...@devtech.com>]

> It struck me that Noel was referring to the [patch tool]
> when he mentioned 'patch'.

Correct.  And the How to Contribute document already describes the normative
process by which someone is requested to submit changes, so what is it that
you would want in the FAQ?

Sergei submitted the change in the manner requested, and I appreciate his
attention to detail.  We should not be contradicting our written policies
unless we intend to change them.  Considering the valid reasons, some of
which Aaron enumerated for you, for leaving the policy as-is, that leaves us
with "we should not be contradicting our written policies."

	--- Noel


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: How to submit/apply code changes

[Harmeet Bedi <ha...@kodemuse.com>]

----- Original Message -----
From: "Noel J. Bergman" <no...@devtech.com>
> what is it that
> you would want in the FAQ?

from my email
> > Add to faq if you think patch or another tool is good information.

Aka. it was left to your discretion. If you feel there is something that
would help others, add it it faq otherwise don't. I did not want to add or
not add anything to FAQ.



Here was the simple request:
From: "Harmeet Bedi" <ha...@kodemuse.com>
> Serge, could you please post the modified DNSServer.java and
> james-config.xml file.
>
> It will be easier to apply the patch if you post these sources.
>

Intent was to save me 5 minutes and was made by me to Serge S.
Instead we are going round and round discussing a process. Not sure why.

I don't think there is any thing wrong in trying to save 5 minutes by asking
for sources, but in hindsight it did not really save any time so not a
worthwhile request.

It has been a good informative session on 'patch'. Hopefully now we can get
back to more germane stuff.

Harmeet


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>