[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1840: [CELEBORN-920] Adding a flag indicating high load in the worker's hea…

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1840:
URL: https://github.com/apache/incubator-celeborn/pull/1840#discussion_r1305538163


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -161,7 +162,8 @@ public void updateWorkerHeartbeatMeta(
     }
     appDiskUsageMetric.update(estimatedAppDiskUsage);
     // If using HDFSONLY mode, workers with empty disks should not be put into excluded worker list.
-    if (!excludedWorkers.contains(worker) && (disks.isEmpty() && !conf.hasHDFSStorage())) {
+    if (!excludedWorkers.contains(worker)
+        && ((disks.isEmpty() && !conf.hasHDFSStorage()) || highWorkload)) {

Review Comment:
   HDFS-only workers' available slots are 0. This will cause workers to get excluded forever.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org