You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by JiaTao Tao <ta...@gmail.com> on 2020/10/21 03:29:17 UTC
Generate a empty Aggregate after RelFieldTrimmer#trim
Hi fellows
I found this in my plan, after RelFieldTrimmer#trim,
`relBuilder.aggregate(groupKey,
newAggCallList);`, the groupKey and newAggCallList are all empty, I think
it doesn't meet expectations.
LogicalAggregate(group=[{}])
LogicalAggregate(group=[{0, 1, 2}])
Regards!
Aron Tao
Re: Generate a empty Aggregate after RelFieldTrimmer#trim
Posted by JiaTao Tao <ta...@gmail.com>.
Copy that, thanks, Julian, I'll follow up this JIRA
Regards!
Aron Tao
Julian Hyde <jh...@apache.org> 于2020年10月22日周四 下午4:33写道：
> I agree with you that a LogicalAggregate with no fields is problematic.
> This is the topic of https://issues.apache.org/jira/browse/CALCITE-4317 <
> https://issues.apache.org/jira/browse/CALCITE-4317>. Let’s continue
> discussion there.
>
> Julian
>
> > On Oct 20, 2020, at 8:29 PM, JiaTao Tao <ta...@gmail.com> wrote:
> >
> > Hi fellows
> > I found this in my plan, after RelFieldTrimmer#trim,
> > `relBuilder.aggregate(groupKey,
> > newAggCallList);`, the groupKey and newAggCallList are all empty, I think
> > it doesn't meet expectations.
> >
> > LogicalAggregate(group=[{}])
> > LogicalAggregate(group=[{0, 1, 2}])
> >
> >
> > Regards!
> >
> > Aron Tao
>
>
Re: Generate a empty Aggregate after RelFieldTrimmer#trim
Posted by Julian Hyde <jh...@apache.org>.
I agree with you that a LogicalAggregate with no fields is problematic. This is the topic of https://issues.apache.org/jira/browse/CALCITE-4317 <https://issues.apache.org/jira/browse/CALCITE-4317>. Let’s continue discussion there.
Julian
> On Oct 20, 2020, at 8:29 PM, JiaTao Tao <ta...@gmail.com> wrote:
>
> Hi fellows
> I found this in my plan, after RelFieldTrimmer#trim,
> `relBuilder.aggregate(groupKey,
> newAggCallList);`, the groupKey and newAggCallList are all empty, I think
> it doesn't meet expectations.
>
> LogicalAggregate(group=[{}])
> LogicalAggregate(group=[{0, 1, 2}])
>
>
> Regards!
>
> Aron Tao