You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/01/25 12:07:18 UTC
[GitHub] [druid] clintropolis commented on a change in pull request #12105: perf: indexing: Introduce a bulk getValuesInto function to read values
clintropolis commented on a change in pull request #12105:
URL: https://github.com/apache/druid/pull/12105#discussion_r791645296
##########
File path: processing/src/main/java/org/apache/druid/segment/DimensionDictionary.java
##########
@@ -84,6 +84,19 @@ public T getValue(int id)
}
}
+ public void getValuesInto(int[] ids, T[] values)
+ {
+ lock.readLock().lock();
+ try {
+ for (int i = 0; i < ids.length; i++) {
Review comment:
#12073 is adding a `StringDimensionDictionary`, so this method might be able to be a bit cleaner in the future, https://github.com/apache/druid/pull/12073/files#diff-f8b1f0a09275a697d95c1d716e7c9f7650cdd2d7021497018df75e4635e4377cR28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org