You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/12/03 21:54:21 UTC

[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3439: [GOBBLIN-1585]GaaS (DagManager) keep retrying a failed job beyond max attempt number

arjun4084346 commented on a change in pull request #3439:
URL: https://github.com/apache/gobblin/pull/3439#discussion_r762308812



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -296,6 +296,14 @@ private static void modifyStateIfRetryRequired(org.apache.gobblin.configuration.
 
     mergedState.putAll(fallbackState.getProperties());
     mergedState.putAll(state.getProperties());
+    // Set CURRENT_ATTEMPTS_FIELD to right value to avoid continually retrying
+    if (fallbackState.getPropAsInt(TimingEvent.FlowEventConstants.CURRENT_ATTEMPTS_FIELD,0) > state.getPropAsInt(TimingEvent.FlowEventConstants.CURRENT_ATTEMPTS_FIELD,0)) {

Review comment:
       Why the default is 0, should not it be 1?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org