You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/11 13:53:42 UTC
[I] [Bug] DLQ resendMessages does not validate start time before end time [rocketmq-dashboard]
tju-yxq opened a new issue, #1802:
URL: https://github.com/apache/rocketmq-dashboard/issues/1802
DLQ resendMessages accepts startTime and endTime without validating begin < end. If startTime > endTime, searchOffset returns inverted results and the scan silently returns zero messages. The message query already has this validation (begin >= end check), but DLQ resend was missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] DLQ resendMessages does not validate start time before end time [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1802:
URL: https://github.com/apache/rocketmq-dashboard/issues/1802#issuecomment-5254291093
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported missing validation has been verified in the DLQ message query flow.
**Root Cause:** `MessageQuery` accepts `begin` and `end` timestamps without validating that `begin < end`. When `begin > end`, `searchOffset` returns inverted results and the scan silently returns zero messages.
**Impact:** Users querying DLQ messages with inverted time ranges get empty results without any error indication, making debugging difficult.
**Severity:** Low-Medium — doesn't cause data corruption but leads to confusing empty results. The regular message query already has this validation.
**Suggested Fix:** Add validation in `queryDlqMessageByPage()` or the controller to check `begin < end` and throw a `ServiceException` if invalid, matching the existing pattern in message query.
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] DLQ resendMessages does not validate start time before end time [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on issue #1802:
URL: https://github.com/apache/rocketmq-dashboard/issues/1802#issuecomment-5270436064
Scope clarification: this issue/PR is specifically about `RocketMQDLQProvider.resendMessages()` rejecting an invalid resend window (`begin >= end`) before creating DLQ consumers or scanning queues.
It is not claiming live verification of `queryDlqMessageByPage()` behavior. The evidence for the current PR is code inspection plus the focused mocked tests listed in the issue body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] DLQ resend should reject invalid time ranges before scanning [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq closed issue #1802: [Bug] DLQ resend should reject invalid time ranges before scanning
URL: https://github.com/apache/rocketmq-dashboard/issues/1802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] DLQ resendMessages does not validate start time before end time [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on issue #1802:
URL: https://github.com/apache/rocketmq-dashboard/issues/1802#issuecomment-5269530448
I updated the PR with focused regression coverage and narrowed the description to what was actually verified.
Verification performed:
```bash
mvn -DskipTests=false "-Dtest=RocketMQDLQProviderTest#resendMessagesShouldRejectInvertedTimeRangeBeforeCreatingConsumers+resendMessagesShouldRejectEqualStartAndEndTimeBeforeCreatingConsumers" test
```
Result: `BUILD SUCCESS`; `Tests run: 2, Failures: 0, Errors: 0, Skipped: 0`.
The evidence is code inspection plus service-level unit tests. I did not live-test this against a RocketMQ broker, so the issue text has been adjusted accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org