You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/18 02:52:33 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1467: Config enhance

LaurenceLiZhixin commented on a change in pull request #1467:
URL: https://github.com/apache/dubbo-go/pull/1467#discussion_r711429720



##########
File path: config/config_center_config.go
##########
@@ -83,13 +83,15 @@ func (c *CenterConfig) check() error {
 	return verify(c)
 }
 
-func (c *CenterConfig) Init(rc *RootConfig) error {

Review comment:
       CenterConfig是rootConfig的指针字段,在这里修改c*CenterConfig 的 c,就会修改rc.ConfigCenter,这里其实不用写回。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org