[jira] [Commented] (HDFS-5683) Better audit log messages for caching operations

["Andrew Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999243#comment-13999243 ] 

Andrew Wang commented on HDFS-5683:
-----------------------------------

Sorry for letting this sit so long Abhiraj, this patch looks good to me. Audit logging is very file-centric right now so the semantics don't fit quite right with the caching methods, but this looks like a strict improvement over what we have right now.

+1 will commit shortly.

> Better audit log messages for caching operations
> ------------------------------------------------
>
>                 Key: HDFS-5683
>                 URL: https://issues.apache.org/jira/browse/HDFS-5683
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Andrew Wang
>              Labels: caching
>             Fix For: 2.5.0
>
>         Attachments: HDFS-5683.001.patch
>
>
> Right now the caching audit logs aren't that useful, e.g.
> {noformat}
> 2013-12-18 14:14:54,423 INFO  FSNamesystem.audit (FSNamesystem.java:logAuditMessage(7362)) - allowed=true	ugi=andrew (auth:SIMPLE)	ip=/127.0.0.1	cmd=addCacheDirective	src=null	dst=null	perm=null
> {noformat}
> It'd be good to include some more information when possible, like the path, pool, id, etc.



--
This message was sent by Atlassian JIRA
(v6.2#6252)