You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "zheheBao (via GitHub)" <gi...@apache.org> on 2023/05/09 15:19:03 UTC
[GitHub] [skywalking-go] zheheBao opened a new pull request, #28: Fix container name inconsistency in file scenarios.tpl
zheheBao opened a new pull request, #28:
URL: https://github.com/apache/skywalking-go/pull/28
When running the run.sh script under skywalking-go/test/plugins, the container name service defined in scenarios.tpl appears_ container_ nameļ¼validator_ container_ name.The connection symbol in name is "_", while the container's connection symbol is "-" after docker-compose.yml is started, which causes the scenario. sh runtime to be unable to obtain the corresponding information, resulting in run.sh failure
Before change
After change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] wu-sheng commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1543237443
So it's working on windows now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] zheheBao commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "zheheBao (via GitHub)" <gi...@apache.org>.
zheheBao commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1541147864
> Following this [question](https://stackoverflow.com/questions/69464001/docker-compose-container-name-use-dash-instead-of-underscore), I think you could check the version of the docker-compose.
I am using a relatively new docker-compose version 2.17.3, which can be resolved by switching to 1.29.2 (the last version of 1.X). Therefore, I tried versions 2.0.0 and 2.0.1 again and found that the issue occurred again
So do we need to add a few lines of script to verify whether docker-compose 1.X or 2.X version, in order to give a prompt to newcomers who encounter my situation when running this script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] mrproliu commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1541153050
> So do we need to add a few lines of script to verify whether docker-compose 1.X or 2.X version, in order to give a prompt to newcomers who encounter my situation when running this script
I think you could add a version judgment and adapter between different docker-compose versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] zheheBao commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "zheheBao (via GitHub)" <gi...@apache.org>.
zheheBao commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540467884
> Do you use Windows for testing the plugin? I think maybe the `docker-compose` has a different name format for the container. For now, the plugins is works well in Linux and MacOS. I think you can judge the system environment and update the name dynamically.
In order to better understand and use skywalking-go, I used Centos7's image to build a virtual machine in VMware. I am not sure if there is a container name issue with docker-compose in the virtual machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] mrproliu commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540463479
Following this [question](https://stackoverflow.com/questions/69464001/docker-compose-container-name-use-dash-instead-of-underscore), I think you could check the version of the docker-compose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] mrproliu merged pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu merged PR #28:
URL: https://github.com/apache/skywalking-go/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] mrproliu commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540429412
> > Do you use Windows for testing the plugin? I think maybe the `docker-compose` has a different name format for the container. For now, the plugins is works well in Linux and MacOS. I think you can judge the system environment and update the name dynamically.
>
>
>
> I think we need to add a Windows e2e to verify at least one plugin? Is that possible? @mrproliu
Sure. I can try it on tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] wu-sheng commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540416848
Which tool are you using to run shell on the windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] wu-sheng commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540409491
This seem breaking the gin plugin test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] zheheBao commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "zheheBao (via GitHub)" <gi...@apache.org>.
zheheBao commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1543241879
> So it's working on windows now?
Currently working on building Linux virtual machines on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] mrproliu commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540408883
Do you use Windows for testing the plugin? I think maybe the `docker-compose` has a different name format for the container. For now, the plugins is works well in Linux and MacOS.
I think you can judge the system environment and update the name dynamically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] wu-sheng commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540413399
> Do you use Windows for testing the plugin? I think maybe the `docker-compose` has a different name format for the container. For now, the plugins is works well in Linux and MacOS. I think you can judge the system environment and update the name dynamically.
I think we need to add a Windows e2e to verify at least one plugin? Is that possible? @mrproliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] zheheBao commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "zheheBao (via GitHub)" <gi...@apache.org>.
zheheBao commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540435368
> Which tool are you using to run shell on the windows?
I used the CentOS7 image to build a virtual machine in VMware
This is the result obtained by using the uname command in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] zheheBao commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "zheheBao (via GitHub)" <gi...@apache.org>.
zheheBao commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1540474016
> Following this [question](https://stackoverflow.com/questions/69464001/docker-compose-container-name-use-dash-instead-of-underscore), I think you could check the version of the docker-compose.
Okay, I'll check it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-go] zheheBao commented on pull request #28: Fix container name inconsistency in file scenarios.tpl
Posted by "zheheBao (via GitHub)" <gi...@apache.org>.
zheheBao commented on PR #28:
URL: https://github.com/apache/skywalking-go/pull/28#issuecomment-1541364807
> I think you could add a version judgment and adapter between different docker-compose versions.
Okay, I'll try it out later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org