You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Aaron Bannert <aa...@clove.org> on 2002/04/09 09:16:35 UTC
apr_lock.h API finally deprecated!
I've finally removed the apr_lock.h API from httpd and apr. I just
did another update on another machine to make sure I didn't miss
anything, but it's still possible that something's weird on a
platform that I don't [normally] use (netware and especialy win32).
I'll make note of this in the CHANGES files shortly, but I wanted
to give a heads up to the lists.
Make sure to remove the export.c and export_vars.h files (or run
make distclean and rerun buildconf and configure), or you may
get some lingering references to apr_lock.h.
-aaron
Re: apr_lock.h API finally deprecated!
Posted by Sebastian Bergmann <li...@sebastian-bergmann.de>.
Aaron Bannert wrote:
> I've finally removed the apr_lock.h API from httpd and apr. I just
> did another update on another machine to make sure I didn't miss
> anything, but it's still possible that something's weird on a
> platform that I don't [normally] use (netware and especialy win32).
> I'll make note of this in the CHANGES files shortly, but I wanted
> to give a heads up to the lists.
Index: apr.dsp
===================================================================
RCS file: /home/cvspublic/apr/apr.dsp,v
retrieving revision 1.98
diff -u -2 -b -w -B -r1.98 apr.dsp
--- apr.dsp 22 Feb 2002 07:11:29 -0000 1.98
+++ apr.dsp 9 Apr 2002 07:24:37 -0000
@@ -171,8 +171,4 @@
# Begin Source File
-SOURCE=.\locks\win32\locks.c
-# End Source File
-# Begin Source File
-
SOURCE=.\locks\win32\proc_mutex.c
# End Source File
@@ -426,8 +422,4 @@
SOURCE=.\include\arch\win32\locks.h
-# End Source File
-# Begin Source File
-
-SOURCE=.\include\arch\win32\misc.h
# End Source File
# Begin Source File
Index: libapr.dsp
===================================================================
RCS file: /home/cvspublic/apr/libapr.dsp,v
retrieving revision 1.59
diff -u -2 -b -w -B -r1.59 libapr.dsp
--- libapr.dsp 22 Feb 2002 07:11:29 -0000 1.59
+++ libapr.dsp 9 Apr 2002 07:24:37 -0000
@@ -177,8 +177,4 @@
# Begin Source File
-SOURCE=.\locks\win32\locks.c
-# End Source File
-# Begin Source File
-
SOURCE=.\locks\win32\proc_mutex.c
# End Source File
@@ -428,8 +424,4 @@
SOURCE=.\include\arch\unix\inherit.h
-# End Source File
-# Begin Source File
-
-SOURCE=.\include\arch\win32\locks.h
# End Source File
# Begin Source File
--
Sebastian Bergmann
http://sebastian-bergmann.de/ http://phpOpenTracker.de/
Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/
Re: apr_lock.h API finally deprecated!
Posted by Aaron Bannert <aa...@clove.org>.
On Tue, Apr 09, 2002 at 09:56:25AM -0500, William A. Rowe, Jr. wrote:
> Done. But did you overlook something?
>
> ssl_engine_mutex.c
> D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(72) : warning C4013:
> 'apr_lock_create' undefined; assuming extern returning int
> D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(72) : error C2065:
> 'APR_MUTEX' : undeclared identifier
> D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(72) : error C2065:
> 'APR_LOCKALL' : undeclared identifier
> D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(89) : warning C4013:
> 'apr_lock_child_init' undefined; assuming extern returning int
> D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(100) : warning C4013:
> 'apr_lock_acquire' undefined; assuming extern returning int
> D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(113) : warning C4013:
> 'apr_lock_release' undefined; assuming extern returning int
Looks like a couple more slipped past me:
aaron@legolas% grep -l apr_lock_create **/*.[ch] ~/work/httpd-2.0
modules/ssl/ssl_engine_mutex.c
server/mpm/beos/beos.c
I'll take care of these right now.
-aaron
Re: apr_lock.h API finally deprecated!
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 02:30 AM 4/9/2002, Aaron Bannert wrote:
>Yup, I just posted something similiar to dev@apr. I was hoping that
>one of the primary win32 developers could fix this up for us.
Done. But did you overlook something?
ssl_engine_mutex.c
D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(72) : warning C4013:
'apr_lock_create' undefined; assuming extern returning int
D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(72) : error C2065:
'APR_MUTEX' : undeclared identifier
D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(72) : error C2065:
'APR_LOCKALL' : undeclared identifier
D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(89) : warning C4013:
'apr_lock_child_init' undefined; assuming extern returning int
D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(100) : warning C4013:
'apr_lock_acquire' undefined; assuming extern returning int
D:\clean\httpd-2.0\modules\ssl\ssl_engine_mutex.c(113) : warning C4013:
'apr_lock_release' undefined; assuming extern returning int
Re: apr_lock.h API finally deprecated!
Posted by Aaron Bannert <aa...@clove.org>.
Yup, I just posted something similiar to dev@apr. I was hoping that
one of the primary win32 developers could fix this up for us.
-aaron
On Tue, Apr 09, 2002 at 09:25:34AM +0200, Sebastian Bergmann wrote:
> Index: apr.dsp
> ===================================================================
> RCS file: /home/cvspublic/apr/apr.dsp,v
> retrieving revision 1.98
> diff -u -2 -b -w -B -r1.98 apr.dsp
> --- apr.dsp 22 Feb 2002 07:11:29 -0000 1.98
> +++ apr.dsp 9 Apr 2002 07:24:37 -0000
> @@ -171,8 +171,4 @@
> # Begin Source File
>
> -SOURCE=.\locks\win32\locks.c
> -# End Source File
> -# Begin Source File
> -
> SOURCE=.\locks\win32\proc_mutex.c
> # End Source File
> @@ -426,8 +422,4 @@
>
> SOURCE=.\include\arch\win32\locks.h
> -# End Source File
> -# Begin Source File
> -
> -SOURCE=.\include\arch\win32\misc.h
> # End Source File
> # Begin Source File
> Index: libapr.dsp
> ===================================================================
> RCS file: /home/cvspublic/apr/libapr.dsp,v
> retrieving revision 1.59
> diff -u -2 -b -w -B -r1.59 libapr.dsp
> --- libapr.dsp 22 Feb 2002 07:11:29 -0000 1.59
> +++ libapr.dsp 9 Apr 2002 07:24:37 -0000
> @@ -177,8 +177,4 @@
> # Begin Source File
>
> -SOURCE=.\locks\win32\locks.c
> -# End Source File
> -# Begin Source File
> -
> SOURCE=.\locks\win32\proc_mutex.c
> # End Source File
> @@ -428,8 +424,4 @@
>
> SOURCE=.\include\arch\unix\inherit.h
> -# End Source File
> -# Begin Source File
> -
> -SOURCE=.\include\arch\win32\locks.h
> # End Source File
> # Begin Source File
>
> --
> Sebastian Bergmann
> http://sebastian-bergmann.de/ http://phpOpenTracker.de/
>
> Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/
Re: apr_lock.h API finally deprecated!
Posted by Aaron Bannert <aa...@clove.org>.
Yup, I just posted something similiar to dev@apr. I was hoping that
one of the primary win32 developers could fix this up for us.
-aaron
On Tue, Apr 09, 2002 at 09:25:34AM +0200, Sebastian Bergmann wrote:
> Index: apr.dsp
> ===================================================================
> RCS file: /home/cvspublic/apr/apr.dsp,v
> retrieving revision 1.98
> diff -u -2 -b -w -B -r1.98 apr.dsp
> --- apr.dsp 22 Feb 2002 07:11:29 -0000 1.98
> +++ apr.dsp 9 Apr 2002 07:24:37 -0000
> @@ -171,8 +171,4 @@
> # Begin Source File
>
> -SOURCE=.\locks\win32\locks.c
> -# End Source File
> -# Begin Source File
> -
> SOURCE=.\locks\win32\proc_mutex.c
> # End Source File
> @@ -426,8 +422,4 @@
>
> SOURCE=.\include\arch\win32\locks.h
> -# End Source File
> -# Begin Source File
> -
> -SOURCE=.\include\arch\win32\misc.h
> # End Source File
> # Begin Source File
> Index: libapr.dsp
> ===================================================================
> RCS file: /home/cvspublic/apr/libapr.dsp,v
> retrieving revision 1.59
> diff -u -2 -b -w -B -r1.59 libapr.dsp
> --- libapr.dsp 22 Feb 2002 07:11:29 -0000 1.59
> +++ libapr.dsp 9 Apr 2002 07:24:37 -0000
> @@ -177,8 +177,4 @@
> # Begin Source File
>
> -SOURCE=.\locks\win32\locks.c
> -# End Source File
> -# Begin Source File
> -
> SOURCE=.\locks\win32\proc_mutex.c
> # End Source File
> @@ -428,8 +424,4 @@
>
> SOURCE=.\include\arch\unix\inherit.h
> -# End Source File
> -# Begin Source File
> -
> -SOURCE=.\include\arch\win32\locks.h
> # End Source File
> # Begin Source File
>
> --
> Sebastian Bergmann
> http://sebastian-bergmann.de/ http://phpOpenTracker.de/
>
> Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/
Re: apr_lock.h API finally deprecated!
Posted by Sebastian Bergmann <li...@sebastian-bergmann.de>.
Aaron Bannert wrote:
> I've finally removed the apr_lock.h API from httpd and apr. I just
> did another update on another machine to make sure I didn't miss
> anything, but it's still possible that something's weird on a
> platform that I don't [normally] use (netware and especialy win32).
Index: apr.dsp
===================================================================
RCS file: /home/cvspublic/apr/apr.dsp,v
retrieving revision 1.98
diff -u -2 -b -w -B -r1.98 apr.dsp
--- apr.dsp 22 Feb 2002 07:11:29 -0000 1.98
+++ apr.dsp 9 Apr 2002 07:24:37 -0000
@@ -171,8 +171,4 @@
# Begin Source File
-SOURCE=.\locks\win32\locks.c
-# End Source File
-# Begin Source File
-
SOURCE=.\locks\win32\proc_mutex.c
# End Source File
@@ -426,8 +422,4 @@
SOURCE=.\include\arch\win32\locks.h
-# End Source File
-# Begin Source File
-
-SOURCE=.\include\arch\win32\misc.h
# End Source File
# Begin Source File
Index: libapr.dsp
===================================================================
RCS file: /home/cvspublic/apr/libapr.dsp,v
retrieving revision 1.59
diff -u -2 -b -w -B -r1.59 libapr.dsp
--- libapr.dsp 22 Feb 2002 07:11:29 -0000 1.59
+++ libapr.dsp 9 Apr 2002 07:24:37 -0000
@@ -177,8 +177,4 @@
# Begin Source File
-SOURCE=.\locks\win32\locks.c
-# End Source File
-# Begin Source File
-
SOURCE=.\locks\win32\proc_mutex.c
# End Source File
@@ -428,8 +424,4 @@
SOURCE=.\include\arch\unix\inherit.h
-# End Source File
-# Begin Source File
-
-SOURCE=.\include\arch\win32\locks.h
# End Source File
# Begin Source File
--
Sebastian Bergmann
http://sebastian-bergmann.de/ http://phpOpenTracker.de/
Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/