You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/12 04:24:51 UTC

[GitHub] [spark] beliefer opened a new pull request, #36516: [SPARK-39157][SQL] H2Dialect should override getJDBCType so as make the data type is correct

beliefer opened a new pull request, #36516:
URL: https://github.com/apache/spark/pull/36516

   ### What changes were proposed in this pull request?
   Currently, H2Dialect not implement getJDBCType of JdbcDialect, so the jdbc data type is incorrect for H2.
   
   
   ### Why are the changes needed?
    make the H2 data type is correct.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'Yes'.
   Fix a bug for H2Dialect.
   
   
   ### How was this patch tested?
   New tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #36516: [SPARK-39157][SQL] H2Dialect should override getJDBCType so as make the data type is correct

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #36516:
URL: https://github.com/apache/spark/pull/36516#issuecomment-1126089024

   thanks, merging to master/3.3!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36516: [SPARK-39157][SQL] H2Dialect should override getJDBCType so as make the data type is correct

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #36516:
URL: https://github.com/apache/spark/pull/36516#issuecomment-1126682083

   @cloud-fan Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36516: [SPARK-39157][SQL] H2Dialect should override getJDBCType so as make the data type is correct

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #36516:
URL: https://github.com/apache/spark/pull/36516#issuecomment-1125809033

   ping @huaxingao cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #36516: [SPARK-39157][SQL] H2Dialect should override getJDBCType so as make the data type is correct

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #36516: [SPARK-39157][SQL] H2Dialect should override getJDBCType so as make the data type is correct
URL: https://github.com/apache/spark/pull/36516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org