You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2015/05/05 16:34:33 UTC

[jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

hsbhathiya wants to merge 1 commit into jclouds:master from hsbhathiya:JCLOUDS-853-2:

Conflicts:
	azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java

Fix Checkstyle Violations

Address live test failiures

Fix Checkstyle Violations

minor changes:

fix live and mocktests

minor changes
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/171

-- Commit Summary --

  * JCLOUDS-853: Improve Create VirtualMachine Deployment

-- File Changes --

    M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (256)
    M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (5)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (845)
    A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161)
    M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (206)
    A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (141)
    A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (180)
    A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (199)
    A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (153)
    M azurecompute/src/main/java/org/jclouds/azurecompute/util/ConflictManagementPredicate.java (2)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (60)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (121)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiLiveTest.java (50)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (81)
    M azurecompute/src/test/java/org/jclouds/azurecompute/internal/AbstractAzureComputeApiLiveTest.java (2)
    A azurecompute/src/test/resources/newdeploymentparams-linux.xml (1)
    A azurecompute/src/test/resources/newdeploymentparams-windows.xml (1)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/171.patch
https://github.com/jclouds/jclouds-labs/pull/171.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

Posted by Bhathiya <no...@github.com>.
Closed #171.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#event-311153739

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

Posted by Ignasi Barrera <no...@github.com>.
Can you please format the code to use a 3 space indent? The diff shows many changed lines only due to this making it quite difficult to see the actual changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-99778596

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

Posted by Bhathiya <no...@github.com>.
@nacx 
Moved to https://github.com/jclouds/jclouds-labs/pull/175 with changes

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-104440913

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

Posted by Ignasi Barrera <no...@github.com>.
@hsbhathiya we really look forward to having this merged. Is there any chance you have some time to dedicate to this PR?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-103523416

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

Posted by Bhathiya <no...@github.com>.
Sorry. I was bit busy last few days. I'll make those changes tomorrow.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-103590397

Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)

Posted by Francesco Chicchiriccò <no...@github.com>.
Hi @hsbhathiya, can you please make the format changes requested by @nacx?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-101271888