You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/21 11:43:20 UTC
[GitHub] [flink] dawidwys opened a new pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
dawidwys opened a new pull request #12945:
URL: https://github.com/apache/flink/pull/12945
## What is the purpose of the change
Adding a generic type to the method makes it possible to pass the type
from a lambda function. Otherwise a wildcard type '?' is derived as
Object and thus TypeExtractor extract a GenericTypeInfo<Object> for the
key.
## Brief change log
* Changed method ConnctedStream#keyBy to accept `KeySelector` of the same generic type in both scala and java API
* Replaced an internal KeySelectorWithType class in scala API with explicitly passing the keyType to the underlying java API.
## Verifying this change
Added test:
* `DataStreamTest#testKeyedConnectedStreamsType`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (**yes** / no / don't know) -> can change serializer for keys in StateBackends
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #12945:
URL: https://github.com/apache/flink/pull/12945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-663402839
Even with the required japicmp exclusion I think this is still a good change. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
}, {
"hash" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833",
"triggerID" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"triggerType" : "PUSH"
}, {
"hash" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4836",
"triggerID" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5aef5007f883d62f11c2e4247f2f5682e9b081e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661806791
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 849a7a97e2536f429f8869beb4b76be6f3354570 (Tue Jul 21 11:45:49 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
}, {
"hash" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833",
"triggerID" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"triggerType" : "PUSH"
}, {
"hash" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4836",
"triggerID" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad777d7b78e3ae98dea1a3b0b845418c2fd3524b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833)
* b5aef5007f883d62f11c2e4247f2f5682e9b081e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 849a7a97e2536f429f8869beb4b76be6f3354570 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 996f5157c9bbf1c48989fe92187038549df0e0fd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #12945:
URL: https://github.com/apache/flink/pull/12945#discussion_r459604168
##########
File path: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/ConnectedStreams.scala
##########
@@ -300,19 +300,22 @@ class ConnectedStreams[IN1, IN2](javaStream: JavaCStream[IN1, IN2]) {
* @param fun2 The second stream's key function
* @return The key-grouped connected streams
*/
- def keyBy[K1: TypeInformation, K2: TypeInformation](fun1: IN1 => K1, fun2: IN2 => K2):
+ def keyBy[KEY: TypeInformation](fun1: IN1 => KEY, fun2: IN2 => KEY):
ConnectedStreams[IN1, IN2] = {
- val keyType1 = implicitly[TypeInformation[K1]]
- val keyType2 = implicitly[TypeInformation[K2]]
-
+ val keyType = implicitly[TypeInformation[KEY]]
+
val cleanFun1 = clean(fun1)
val cleanFun2 = clean(fun2)
-
- val keyExtractor1 = new KeySelectorWithType[IN1, K1](cleanFun1, keyType1)
- val keyExtractor2 = new KeySelectorWithType[IN2, K2](cleanFun2, keyType2)
-
- asScalaStream(javaStream.keyBy(keyExtractor1, keyExtractor2))
+
+ val keyExtractor1 = new KeySelector[IN1, KEY] {
Review comment:
I reverted the internal class.
My main goal here was to pass the key type explicitly rather than through the `ResultTypeQueryable`, which requires running `TypeExtractor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 849a7a97e2536f429f8869beb4b76be6f3354570 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683)
* 996f5157c9bbf1c48989fe92187038549df0e0fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 849a7a97e2536f429f8869beb4b76be6f3354570 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
}, {
"hash" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833",
"triggerID" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad777d7b78e3ae98dea1a3b0b845418c2fd3524b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12945:
URL: https://github.com/apache/flink/pull/12945#discussion_r459443786
##########
File path: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/ConnectedStreams.scala
##########
@@ -300,19 +300,22 @@ class ConnectedStreams[IN1, IN2](javaStream: JavaCStream[IN1, IN2]) {
* @param fun2 The second stream's key function
* @return The key-grouped connected streams
*/
- def keyBy[K1: TypeInformation, K2: TypeInformation](fun1: IN1 => K1, fun2: IN2 => K2):
+ def keyBy[KEY: TypeInformation](fun1: IN1 => KEY, fun2: IN2 => KEY):
ConnectedStreams[IN1, IN2] = {
- val keyType1 = implicitly[TypeInformation[K1]]
- val keyType2 = implicitly[TypeInformation[K2]]
-
+ val keyType = implicitly[TypeInformation[KEY]]
+
val cleanFun1 = clean(fun1)
val cleanFun2 = clean(fun2)
-
- val keyExtractor1 = new KeySelectorWithType[IN1, K1](cleanFun1, keyType1)
- val keyExtractor2 = new KeySelectorWithType[IN2, K2](cleanFun2, keyType2)
-
- asScalaStream(javaStream.keyBy(keyExtractor1, keyExtractor2))
+
+ val keyExtractor1 = new KeySelector[IN1, KEY] {
Review comment:
nit: I like the simplicity of the code but I think stacktraces are harder to parse with anonymous classes thrown in the mix. Just a thought, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
}, {
"hash" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833",
"triggerID" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"triggerType" : "PUSH"
}, {
"hash" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad777d7b78e3ae98dea1a3b0b845418c2fd3524b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833)
* b5aef5007f883d62f11c2e4247f2f5682e9b081e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
}, {
"hash" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4833",
"triggerID" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"triggerType" : "PUSH"
}, {
"hash" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5aef5007f883d62f11c2e4247f2f5682e9b081e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5aef5007f883d62f11c2e4247f2f5682e9b081e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12945: [FLINK-18629] Add type to ConnectedStreams#keyBy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12945:
URL: https://github.com/apache/flink/pull/12945#issuecomment-661810553
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4683",
"triggerID" : "849a7a97e2536f429f8869beb4b76be6f3354570",
"triggerType" : "PUSH"
}, {
"hash" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691",
"triggerID" : "996f5157c9bbf1c48989fe92187038549df0e0fd",
"triggerType" : "PUSH"
}, {
"hash" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad777d7b78e3ae98dea1a3b0b845418c2fd3524b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 996f5157c9bbf1c48989fe92187038549df0e0fd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4691)
* ad777d7b78e3ae98dea1a3b0b845418c2fd3524b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org