[GitHub] [activemq] lucastetreault commented on pull request #870: [AMQ-9005] remove xalan dependency due to it being end of life

[GitBox <gi...@apache.org>]

lucastetreault commented on PR #870:
URL: https://github.com/apache/activemq/pull/870#issuecomment-1201470213

   > Other xalan references need to be cleaned up and XPath unit tests validated
   > 
   > ./activemq-client/src/main/java/org/apache/activemq/filter/XPathExpression.java ./activemq-broker/src/main/java/org/apache/activemq/filter/XalanXPathEvaluator.java
   
   So I'm not entirely sure what to do with these...
   
   activemq-broker/src/main/java/org/apache/activemq/filter/XalanXPathEvaluator is actually identical to activemq-broker/src/main/java/org/apache/activemq/filter/JAXPXPathEvaluator and neither of them use Xalan. I guess we can delete XalanXPathEvaluator and change the reference to it in XPathExpression to use JAXPXPathEvaluator. 
   
   The SelectorParserTest is the only test I can find using XPathExpression and it passes with these changes. 
   
   > > xalan reference missed:
   > > https://github.com/apache/activemq/blob/main/assembly/src/release/examples/conf/resin-web.xml
   > 
   > I'm guessing but that TransformerFactory setting can probably just be removed. That would likely mean that the JDK built-in transformer is used (unless another JAXP compliant transformer was on the classpath, eg Saxon).
   
   I don't know anything about resin. How can I test this? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org