[GitHub] [spark] cloud-fan commented on a change in pull request #26283: [SPARK-29622][SQL] do not allow leading 'interval' in the interval string format

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26283: [SPARK-29622][SQL] do not allow leading 'interval' in the interval string format
URL: https://github.com/apache/spark/pull/26283#discussion_r339595590
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -1930,71 +1917,73 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
   }
 
   /**
-   * Create a [[CalendarInterval]] literal expression. An interval expression can contain multiple
-   * unit value pairs, for instance: interval 2 months 2 days.
+   * Creates a [[CalendarInterval]] literal expression with multiple units, e.g. 1 YEAR 2 DAYS.
    */
-  override def visitInterval(ctx: IntervalContext): Literal = withOrigin(ctx) {
-    val intervals = ctx.intervalField.asScala.map(visitIntervalField)
-    validate(intervals.nonEmpty, "at least one time unit should be given for interval literal", ctx)
-    Literal(intervals.reduce(_.add(_)))
-  }
+  override def visitMultiUnitsInterval(ctx: MultiUnitsIntervalContext): CalendarInterval = {
 
 Review comment:
   This is mostly the original `visitSingleInterval`, with some methods inlined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org