[GitHub] [bookkeeper] michaeljmarshall commented on a diff in pull request #3979: Fix Journal without flush

["michaeljmarshall (via GitHub)" <gi...@apache.org>]

michaeljmarshall commented on code in PR #3979:
URL: https://github.com/apache/bookkeeper/pull/3979#discussion_r1218984407


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -421,6 +421,7 @@ private ForceWriteRequest(Handle<ForceWriteRequest> recyclerHandle) {
 
         private void recycle() {
             logFile = null;
+            flushed = false;

Review Comment:
   This kind of bug is completely avoided by removing object recycling. I understand that object recycling was added a while ago, but I wonder if it is still necessary on JVM 17. It'd be valuable to run benchmarks to verify the underlying assumption that we get better performance by recycling objects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org