You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/26 10:32:25 UTC
Review Request 46680: Fixed docker volume isolator const ref and vlog
quotation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46680/
-----------------------------------------------------------
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Repository: mesos
Description
-------
Fixed docker volume isolator const ref and vlog quotation.
Diffs
-----
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d
Diff: https://reviews.apache.org/r/46680/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 46680: Fixed docker volume isolator const ref and
vlog quotation.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46680/#review130576
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 201)
<https://reviews.apache.org/r/46680/#comment194411>
remove the quota here?
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 289 - 290)
<https://reviews.apache.org/r/46680/#comment194410>
According to https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#capture-by-reference , seems we disallow capturing temporaries by reference?
Can you please add some detail in description for why using reference here?
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 473)
<https://reviews.apache.org/r/46680/#comment194412>
remove quota?
- Guangya Liu
On April 26, 2016, 8:32 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46680/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:32 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed docker volume isolator const ref and vlog quotation.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d
>
> Diff: https://reviews.apache.org/r/46680/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>