You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2016/09/08 08:15:15 UTC
[GitHub] incubator-carbondata pull request #143: [CARBONDATA-229] Array Index of boun...
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/143
[CARBONDATA-229] Array Index of bound exception thrown from dictionary look up while writing sort index file
Problem: Array Index of bound exception thrown from dictionary look up while writing sort index file
Analysis: Whenever we load dictionary data into memory, then in case of populating reverse dictionary object sometimes a chunk which has no value is also getting added to the dictionary chunk list. This is happening because the logic for dictionary chunk distribution in case of forward dictionary is not implemented for reverse dictionary and 0 size dictionary chunks are not getting removed while adding to the list of dictionary chunks.
Solution: Add the same distribution logic we have in forward dictionary for populating reverse dictionary object
Impact area: Sort index generation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishgupta88/incubator-carbondata dictionary_chunk_addition_issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #143
----
commit 1102eed75692b6c0d4094a6e7f71e83464453d13
Author: manishgupta88 <to...@gmail.com>
Date: 2016-09-08T07:38:56Z
Problem: Array Index of bound exception thrown from dictionary look up while writing sort index file
Analysis: Whenever we load dictionary data into memory, then in case of populating reverse dictionary object sometimes a chunk which has no value is also getting added to the dictionary chunk list. This is happening because the logic for dictionary chunk distribution in case of forward dictionary is not implemented for reverse dictionary and 0 size dictionary chunks are not getting removed while adding to the list of dictionary chunks.
Solution: Add the same distribution logic we have in forward dictionary for populating reverse dictionary object
Impact area: Sort index generation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #143: [CARBONDATA-229] Array Index of boun...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---