You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rags22489664 <gi...@git.apache.org> on 2015/10/19 13:19:30 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8929: The list of VMs that can...
GitHub user rags22489664 opened a pull request:
https://github.com/apache/cloudstack/pull/949
CLOUDSTACK-8929: The list of VMs that can be assigned to a load balancer rule is not updated after a VM is assigned to it.
Once we assign a VM to a load balancer rule, the VM should not appear again for the same rule.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rags22489664/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 4f79c148e3545eb8dc4c2bf78c646a19bc55abfc
Author: ramamurtis <ra...@citrix.com>
Date: 2015-10-01T09:39:57Z
CLOUDSTACK-8929: After a load balancer rule is created and if another VM is assigned to it, it still shows up in the list of VMs that can be assigned to it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929: The list of VMs that can...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/949#issuecomment-149960464
Awesome, @rags22489664 !
I will test this one tomorrow. Is there any integration test that would cover that case? If not, I will do some manual tests and try to get some integration tests in when I have some time.
Thanks for the PR.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929: The list of VMs that can...
Posted by rags22489664 <gi...@git.apache.org>.
Github user rags22489664 closed the pull request at:
https://github.com/apache/cloudstack/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929: The list of VMs that can...
Posted by rags22489664 <gi...@git.apache.org>.
Github user rags22489664 commented on the pull request:
https://github.com/apache/cloudstack/pull/949#issuecomment-149188565
Sorry for the ambiguous pull request earlier. I have updated the defect and created this pull request with proper description (Hopefully).
As for the comment (https://github.com/apache/cloudstack/pull/904#issuecomment-144700051)
This fix does not remove the VM from other rules, just from the one in which it is already added
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---