You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2021/04/21 08:52:12 UTC
[DISCUSS] Make wicket-http2 a stable module
Hi,
Shall we make wicket-http2 a stable module now in master branch (Wicket
10.x) ?
There we upgraded from Servlet 3 to Servlet 5 and this makes PushBuilder
class available (it is introduced in Servlet 4).
I suggest to drop the modules for Tomcat, Jetty and Undertow, and merge the
classes from -servlet4 and -core modules into one (wicket-http2) or to move
them to -core directly.
WDYT ?
Martin
Re: [DISCUSS] Make wicket-http2 a stable module
Posted by Martin Grigorov <mg...@apache.org>.
Thanks to all who responded!
https://issues.apache.org/jira/browse/WICKET-6887
On Thu, Apr 22, 2021 at 11:03 PM Andrea Del Bene <an...@gmail.com>
wrote:
> +1 to make the module stable
>
> On Wed, Apr 21, 2021 at 5:23 PM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > +1
> >
> > from mobile (sorry for typos ;)
> >
> >
> > On Wed, Apr 21, 2021, 16:52 Tobias Soloschenko
> > <to...@googlemail.com.invalid> wrote:
> >
> > > Good idea. My suggestion would be to move it into core directly,
> because
> > > it is standard servlet API as of version 4.
> > >
> > > Any other opinions?
> > >
> > > kind regards
> > >
> > > Tobias
> > >
> > > > Am 21.04.2021 um 10:52 schrieb Martin Grigorov <mgrigorov@apache.org
> >:
> > > >
> > > > Hi,
> > > >
> > > > Shall we make wicket-http2 a stable module now in master branch
> (Wicket
> > > > 10.x) ?
> > > > There we upgraded from Servlet 3 to Servlet 5 and this makes
> > PushBuilder
> > > > class available (it is introduced in Servlet 4).
> > > >
> > > > I suggest to drop the modules for Tomcat, Jetty and Undertow, and
> merge
> > > the
> > > > classes from -servlet4 and -core modules into one (wicket-http2) or
> to
> > > move
> > > > them to -core directly.
> > > >
> > > > WDYT ?
> > > >
> > > > Martin
> > >
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
Re: [DISCUSS] Make wicket-http2 a stable module
Posted by Andrea Del Bene <an...@gmail.com>.
+1 to make the module stable
On Wed, Apr 21, 2021 at 5:23 PM Maxim Solodovnik <so...@gmail.com>
wrote:
> +1
>
> from mobile (sorry for typos ;)
>
>
> On Wed, Apr 21, 2021, 16:52 Tobias Soloschenko
> <to...@googlemail.com.invalid> wrote:
>
> > Good idea. My suggestion would be to move it into core directly, because
> > it is standard servlet API as of version 4.
> >
> > Any other opinions?
> >
> > kind regards
> >
> > Tobias
> >
> > > Am 21.04.2021 um 10:52 schrieb Martin Grigorov <mg...@apache.org>:
> > >
> > > Hi,
> > >
> > > Shall we make wicket-http2 a stable module now in master branch (Wicket
> > > 10.x) ?
> > > There we upgraded from Servlet 3 to Servlet 5 and this makes
> PushBuilder
> > > class available (it is introduced in Servlet 4).
> > >
> > > I suggest to drop the modules for Tomcat, Jetty and Undertow, and merge
> > the
> > > classes from -servlet4 and -core modules into one (wicket-http2) or to
> > move
> > > them to -core directly.
> > >
> > > WDYT ?
> > >
> > > Martin
> >
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [DISCUSS] Make wicket-http2 a stable module
Posted by Maxim Solodovnik <so...@gmail.com>.
+1
from mobile (sorry for typos ;)
On Wed, Apr 21, 2021, 16:52 Tobias Soloschenko
<to...@googlemail.com.invalid> wrote:
> Good idea. My suggestion would be to move it into core directly, because
> it is standard servlet API as of version 4.
>
> Any other opinions?
>
> kind regards
>
> Tobias
>
> > Am 21.04.2021 um 10:52 schrieb Martin Grigorov <mg...@apache.org>:
> >
> > Hi,
> >
> > Shall we make wicket-http2 a stable module now in master branch (Wicket
> > 10.x) ?
> > There we upgraded from Servlet 3 to Servlet 5 and this makes PushBuilder
> > class available (it is introduced in Servlet 4).
> >
> > I suggest to drop the modules for Tomcat, Jetty and Undertow, and merge
> the
> > classes from -servlet4 and -core modules into one (wicket-http2) or to
> move
> > them to -core directly.
> >
> > WDYT ?
> >
> > Martin
>
Re: [DISCUSS] Make wicket-http2 a stable module
Posted by Tobias Soloschenko <to...@googlemail.com.INVALID>.
Good idea. My suggestion would be to move it into core directly, because it is standard servlet API as of version 4.
Any other opinions?
kind regards
Tobias
> Am 21.04.2021 um 10:52 schrieb Martin Grigorov <mg...@apache.org>:
>
> Hi,
>
> Shall we make wicket-http2 a stable module now in master branch (Wicket
> 10.x) ?
> There we upgraded from Servlet 3 to Servlet 5 and this makes PushBuilder
> class available (it is introduced in Servlet 4).
>
> I suggest to drop the modules for Tomcat, Jetty and Undertow, and merge the
> classes from -servlet4 and -core modules into one (wicket-http2) or to move
> them to -core directly.
>
> WDYT ?
>
> Martin