You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/23 20:24:02 UTC
[kudu-CR] [util] fix build on OS X
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9433
Change subject: [util] fix build on OS X
......................................................................
[util] fix build on OS X
This is a follow-up for c20b84bb600575e4f6a34846c07acf4603b1bf26.
Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
---
M src/kudu/util/debug-util.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9433/1
--
To view, visit http://gerrit.cloudera.org:8080/9433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Gerrit-Change-Number: 9433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] fix build on OS X
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9433 )
Change subject: [util] fix build on OS X
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Gerrit-Change-Number: 9433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 20:34:22 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix build on OS X
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9433 )
Change subject: [util] fix build on OS X
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Gerrit-Change-Number: 9433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 20:28:18 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix build on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9433 )
Change subject: [util] fix build on OS X
......................................................................
Patch Set 1:
> Build Started http://jenkins.kudu.apache.org/job/kudu-gerrit/12197/
IWYU warnings are about to be addressed in a separate patch.
--
To view, visit http://gerrit.cloudera.org:8080/9433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Gerrit-Change-Number: 9433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 21:10:05 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix build on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9433 )
Change subject: [util] fix build on OS X
......................................................................
[util] fix build on OS X
This is a follow-up for c20b84bb600575e4f6a34846c07acf4603b1bf26.
Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Reviewed-on: http://gerrit.cloudera.org:8080/9433
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/debug-util.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Dan Burkert: Looks good to me, but someone else must approve
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Gerrit-Change-Number: 9433
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [util] fix build on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9433 )
Change subject: [util] fix build on OS X
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8905e412a036ef4ca9fbedc589d01a8d79eb0c7
Gerrit-Change-Number: 9433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 21:09:39 +0000
Gerrit-HasComments: No