[GitHub] [hadoop] mukund-thakur commented on a change in pull request #1875: HADOOP-16794. S3A reverts KMS encryption to the bucket's default KMS …

[GitBox <gi...@apache.org>]

mukund-thakur commented on a change in pull request #1875: HADOOP-16794. S3A reverts KMS encryption to the bucket's default KMS …
URL: https://github.com/apache/hadoop/pull/1875#discussion_r388121940
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java
 ##########
 @@ -42,11 +46,24 @@
   protected Configuration createConfiguration() {
     Configuration conf = super.createConfiguration();
     S3ATestUtils.disableFilesystemCaching(conf);
-    conf.set(Constants.SERVER_SIDE_ENCRYPTION_ALGORITHM,
-            getSSEAlgorithm().getMethod());
+    patchConfigurationEncryptionSettings(conf);
     return conf;
   }
 
+  /**
+   * This removes the encryption settings from the
 
 Review comment:
   Yes comment is misleading. I had to fix the merge conflict and as removeBaseAndBucketOverrides() was not present earlier I had to delete that line thinking it is not required. 
   
   Although I can see the same method is present in S3ATestUtils but with different parameters and it is not used in this test. 
   @steveloughran  Do you also think tests might break here if bucket level conf are set? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org