You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 19:21:23 UTC
[GitHub] [airflow] XD-DENG opened a new issue #12818: Don't have session.commit() when @provide_session decorator is used
XD-DENG opened a new issue #12818:
URL: https://github.com/apache/airflow/issues/12818
As discussed in https://github.com/apache/airflow/pull/12815#discussion_r536283503 and pointed out at https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#database-session-handling, we should not have `session.commit()` when `@provide_session` decorator is used (for principle "Explicit is better than implicit").
This issue exists in files like https://github.com/apache/airflow/blob/2936c13a44369daae9d6099cd1070b3a8cd53443/airflow/models/dag.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SamWheating commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
SamWheating commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-738988030
I'd be interested in taking this one on, feel free to assign me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
chenglongyan commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-1075440106
@potiuk I need to close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-1077373247
I think it will be closed when merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dev232001 commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
Dev232001 commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-1048509363
assign this to me please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dev232001 commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
Dev232001 commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-1053275825
Didn't @chenglongyan already merged the pull request for this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-738988589
Cool. Assigned to you @SamWheating
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-1053741352
Not yet merged but yeah https://github.com/apache/airflow/pull/21283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #12818: Don't have session.commit() when @provide_session decorator is used
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #12818:
URL: https://github.com/apache/airflow/issues/12818#issuecomment-981063668
@SamWheating Do you plan to finish the stale PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org