You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "anton-vinogradov (via GitHub)" <gi...@apache.org> on 2023/08/07 19:45:02 UTC
[GitHub] [ignite] anton-vinogradov opened a new pull request, #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
anton-vinogradov opened a new pull request, #10883:
URL: https://github.com/apache/ignite/pull/10883
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1290017897
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -109,46 +106,43 @@ public final class GridDhtLockFuture extends GridCacheCompoundIdentityFuture<Boo
/** Cache registry. */
@GridToStringExclude
- private GridCacheContext<?, ?> cctx;
+ private final GridCacheContext<?, ?> cctx;
/** Near node ID. */
- private UUID nearNodeId;
+ private final UUID nearNodeId;
/** Near lock version. */
- private GridCacheVersion nearLockVer;
+ private final GridCacheVersion nearLockVer;
/** Topology version. */
- private AffinityTopologyVersion topVer;
+ private final AffinityTopologyVersion topVer;
/** Thread. */
- private long threadId;
+ private final long threadId;
/**
* Keys locked so far.
- *
Review Comment:
This will change the javadoc :)
\* with a blank line was just ignored. So, nothing changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1290017897
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -109,46 +106,43 @@ public final class GridDhtLockFuture extends GridCacheCompoundIdentityFuture<Boo
/** Cache registry. */
@GridToStringExclude
- private GridCacheContext<?, ?> cctx;
+ private final GridCacheContext<?, ?> cctx;
/** Near node ID. */
- private UUID nearNodeId;
+ private final UUID nearNodeId;
/** Near lock version. */
- private GridCacheVersion nearLockVer;
+ private final GridCacheVersion nearLockVer;
/** Topology version. */
- private AffinityTopologyVersion topVer;
+ private final AffinityTopologyVersion topVer;
/** Thread. */
- private long threadId;
+ private final long threadId;
/**
* Keys locked so far.
- *
Review Comment:
This will change the javadoc :)
* with a blank line was just ignored. So, nothing changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1290133042
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -286,14 +274,12 @@ public GridDhtLockFuture(
assert fut instanceof GridDhtColocatedLockFuture : fut;
// Terminate this future if parent(collocated) future is terminated by rollback.
- fut.listen(new IgniteInClosure<IgniteInternalFuture>() {
- @Override public void apply(IgniteInternalFuture fut) {
- try {
- fut.get();
- }
- catch (IgniteCheckedException e) {
- onError(e);
- }
+ fut.listen((IgniteInternalFuture<?> fut0) -> {
+ try {
+ fut.get();
Review Comment:
Duplicate removal
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheTxRecoveryFuture.java:
##########
@@ -223,27 +217,25 @@ public void prepare() {
}
}
else {
- fut.listen(new CI1<IgniteInternalFuture<Boolean>>() {
- @Override public void apply(IgniteInternalFuture<Boolean> fut) {
- boolean prepared;
+ fut.listen((IgniteInternalFuture<Boolean> fut0) -> {
+ boolean prepared;
- try {
- prepared = fut.get();
- }
- catch (IgniteCheckedException e) {
- U.error(log, "Check prepared transaction future failed: " + e, e);
+ try {
+ prepared = fut.get();
Review Comment:
Duplicate removal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov merged pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov merged PR #10883:
URL: https://github.com/apache/ignite/pull/10883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1290132740
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheTxRecoveryFuture.java:
##########
@@ -143,14 +139,12 @@ public void prepare() {
if (cctx.localNodeId().equals(nearNodeId)) {
IgniteInternalFuture<Boolean> fut = cctx.tm().txCommitted(tx.nearXidVersion());
- fut.listen(new CI1<IgniteInternalFuture<Boolean>>() {
- @Override public void apply(IgniteInternalFuture<Boolean> fut) {
- try {
- onDone(fut.get());
- }
- catch (IgniteCheckedException e) {
- onDone(e);
- }
+ fut.listen((IgniteInternalFuture<Boolean> fut0) -> {
+ try {
+ onDone(fut.get());
Review Comment:
Duplicate removal
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheTxRecoveryFuture.java:
##########
@@ -223,27 +217,25 @@ public void prepare() {
}
}
else {
- fut.listen(new CI1<IgniteInternalFuture<Boolean>>() {
- @Override public void apply(IgniteInternalFuture<Boolean> fut) {
- boolean prepared;
+ fut.listen((IgniteInternalFuture<Boolean> fut0) -> {
+ boolean prepared;
- try {
- prepared = fut.get();
- }
- catch (IgniteCheckedException e) {
- U.error(log, "Check prepared transaction future failed: " + e, e);
+ try {
+ prepared = fut.get();
Review Comment:
Duplicat removal
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -286,14 +274,12 @@ public GridDhtLockFuture(
assert fut instanceof GridDhtColocatedLockFuture : fut;
// Terminate this future if parent(collocated) future is terminated by rollback.
- fut.listen(new IgniteInClosure<IgniteInternalFuture>() {
- @Override public void apply(IgniteInternalFuture fut) {
- try {
- fut.get();
- }
- catch (IgniteCheckedException e) {
- onError(e);
- }
+ fut.listen((IgniteInternalFuture<?> fut0) -> {
+ try {
+ fut.get();
Review Comment:
Duplicat removal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10883:
URL: https://github.com/apache/ignite/pull/10883#issuecomment-1668486284
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10883)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1290133695
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java:
##########
@@ -915,19 +910,17 @@ synchronized void mapOnTopology(final boolean remap) {
markInitialized();
}
else {
- fut.listen(new CI1<IgniteInternalFuture<AffinityTopologyVersion>>() {
- @Override public void apply(IgniteInternalFuture<AffinityTopologyVersion> fut) {
- try {
- fut.get();
+ fut.listen((IgniteInternalFuture<AffinityTopologyVersion> fut0) -> {
+ try {
+ fut.get();
Review Comment:
Duplicate removal
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java:
##########
@@ -1473,25 +1466,23 @@ private class LockTimeoutObject extends GridTimeoutObjectAdapter {
IgniteInternalFuture<TxDeadlock> fut = cctx.tm().detectDeadlock(tx, keys);
- fut.listen(new IgniteInClosure<IgniteInternalFuture<TxDeadlock>>() {
- @Override public void apply(IgniteInternalFuture<TxDeadlock> fut) {
- try {
- TxDeadlock deadlock = fut.get();
+ fut.listen((IgniteInternalFuture<TxDeadlock> fut0) -> {
+ try {
+ TxDeadlock deadlock = fut.get();
Review Comment:
Duplicate removal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10883:
URL: https://github.com/apache/ignite/pull/10883#issuecomment-1673245378
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10883)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL) [25 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10883:
URL: https://github.com/apache/ignite/pull/10883#issuecomment-1669645336
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10883)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10883&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL) [25 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10883&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_duplicated_lines_density&view=list) [8.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10883&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1287634828
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -109,46 +106,43 @@ public final class GridDhtLockFuture extends GridCacheCompoundIdentityFuture<Boo
/** Cache registry. */
@GridToStringExclude
- private GridCacheContext<?, ?> cctx;
+ private final GridCacheContext<?, ?> cctx;
/** Near node ID. */
- private UUID nearNodeId;
+ private final UUID nearNodeId;
/** Near lock version. */
- private GridCacheVersion nearLockVer;
+ private final GridCacheVersion nearLockVer;
/** Topology version. */
- private AffinityTopologyVersion topVer;
+ private final AffinityTopologyVersion topVer;
/** Thread. */
- private long threadId;
+ private final long threadId;
/**
* Keys locked so far.
- *
Review Comment:
Replace with tag `<p>`?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheTxRecoveryFuture.java:
##########
@@ -143,14 +139,12 @@ public void prepare() {
if (cctx.localNodeId().equals(nearNodeId)) {
IgniteInternalFuture<Boolean> fut = cctx.tm().txCommitted(tx.nearXidVersion());
- fut.listen(new CI1<IgniteInternalFuture<Boolean>>() {
- @Override public void apply(IgniteInternalFuture<Boolean> fut) {
- try {
- onDone(fut.get());
- }
- catch (IgniteCheckedException e) {
- onDone(e);
- }
+ fut.listen((IgniteInternalFuture<Boolean> fut0) -> {
+ try {
+ onDone(fut.get());
Review Comment:
fut -> fut0?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -286,14 +274,12 @@ public GridDhtLockFuture(
assert fut instanceof GridDhtColocatedLockFuture : fut;
// Terminate this future if parent(collocated) future is terminated by rollback.
- fut.listen(new IgniteInClosure<IgniteInternalFuture>() {
- @Override public void apply(IgniteInternalFuture fut) {
- try {
- fut.get();
- }
- catch (IgniteCheckedException e) {
- onError(e);
- }
+ fut.listen((IgniteInternalFuture<?> fut0) -> {
+ try {
+ fut.get();
Review Comment:
fut -> fut0
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java:
##########
@@ -1473,25 +1466,23 @@ private class LockTimeoutObject extends GridTimeoutObjectAdapter {
IgniteInternalFuture<TxDeadlock> fut = cctx.tm().detectDeadlock(tx, keys);
- fut.listen(new IgniteInClosure<IgniteInternalFuture<TxDeadlock>>() {
- @Override public void apply(IgniteInternalFuture<TxDeadlock> fut) {
- try {
- TxDeadlock deadlock = fut.get();
+ fut.listen((IgniteInternalFuture<TxDeadlock> fut0) -> {
+ try {
+ TxDeadlock deadlock = fut.get();
Review Comment:
fut -> fut0
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java:
##########
@@ -915,19 +910,17 @@ synchronized void mapOnTopology(final boolean remap) {
markInitialized();
}
else {
- fut.listen(new CI1<IgniteInternalFuture<AffinityTopologyVersion>>() {
- @Override public void apply(IgniteInternalFuture<AffinityTopologyVersion> fut) {
- try {
- fut.get();
+ fut.listen((IgniteInternalFuture<AffinityTopologyVersion> fut0) -> {
+ try {
+ fut.get();
Review Comment:
fut -> fut0?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheTxRecoveryFuture.java:
##########
@@ -223,27 +217,25 @@ public void prepare() {
}
}
else {
- fut.listen(new CI1<IgniteInternalFuture<Boolean>>() {
- @Override public void apply(IgniteInternalFuture<Boolean> fut) {
- boolean prepared;
+ fut.listen((IgniteInternalFuture<Boolean> fut0) -> {
+ boolean prepared;
- try {
- prepared = fut.get();
- }
- catch (IgniteCheckedException e) {
- U.error(log, "Check prepared transaction future failed: " + e, e);
+ try {
+ prepared = fut.get();
Review Comment:
fut -> fut0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10883: IGNITE-20177 GridCacheCompoundIdentityFuture's child-free descendants initial cleanup
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #10883:
URL: https://github.com/apache/ignite/pull/10883#discussion_r1290138668
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java:
##########
@@ -109,46 +106,43 @@ public final class GridDhtLockFuture extends GridCacheCompoundIdentityFuture<Boo
/** Cache registry. */
@GridToStringExclude
- private GridCacheContext<?, ?> cctx;
+ private final GridCacheContext<?, ?> cctx;
/** Near node ID. */
- private UUID nearNodeId;
+ private final UUID nearNodeId;
/** Near lock version. */
- private GridCacheVersion nearLockVer;
+ private final GridCacheVersion nearLockVer;
/** Topology version. */
- private AffinityTopologyVersion topVer;
+ private final AffinityTopologyVersion topVer;
/** Thread. */
- private long threadId;
+ private final long threadId;
/**
* Keys locked so far.
- *
Review Comment:
Done %)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org