You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/05 09:39:22 UTC

[GitHub] [airflow] potiuk opened a new pull request #10750: Make static checks Google Shell Guide compatible

potiuk opened a new pull request #10750:
URL: https://github.com/apache/airflow/pull/10750


   Part #10576
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #10750: Make static checks Google Shell Guide compatible

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10750:
URL: https://github.com/apache/airflow/pull/10750#discussion_r483985601



##########
File path: .pre-commit-config.yaml
##########
@@ -223,7 +223,7 @@ repos:
         name: Lint dockerfile
         language: system
         entry: "./scripts/ci/pre_commit/pre_commit_lint_dockerfile.sh"
-        files: ^Dockerfile.*$
+        files: Dockerfile.*$

Review comment:
       ```suggestion
           files: ^Dockerfile.*$
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #10750: Make static checks Google Shell Guide compatible

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10750:
URL: https://github.com/apache/airflow/pull/10750


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org