[GitHub] flink pull request #5303: [hotfix][docs] Adjust RocksDb dependency docs

[zentol <gi...@git.apache.org>]

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5303

    [hotfix][docs] Adjust RocksDb dependency docs

    Small adjustment as per https://github.com/apache/flink/commit/5623ac66bd145d52f3488ac2fff9dbc762d0bda1#commitcomment-26867793.
    
    @StephanEwen @rmetzger 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink hotfix_rocks_docs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5303
    
----
commit 2a2aaced539073d823d5ab87027cd96cdac09ad3
Author: zentol <ch...@...>
Date:   2018-01-16T12:32:36Z

    [hotfix][docs] Adjust RocksDb dependency docs

----


---

[GitHub] flink issue #5303: [hotfix][docs] Adjust RocksDb dependency docs

[zentol <gi...@git.apache.org>]

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5303
  
    In that case I'll revert the commit that caused all this, close this PR and open a new JIRA for adding a new dependency management section to the project setup guide (along with a sweep across the docs/quickstarts etc.).


---

[GitHub] flink issue #5303: [hotfix][docs] Adjust RocksDb dependency docs

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5303
  
    I would suggest to start thinking about the dependencies the following way:
    
      - There are pure user-code projects where the Flink runtime is "provided" and they are started using an existing Flink setup (`bin/flink run` or REST entry point). This is the **Framework Style**.
    
      - In the future, we will have "Flink as a Library" deployments, where users add something like `flink-dist` as a library to their program and then simply dockerize that Java application.
    
      - Code can be run in the IDE or other similar style embedded forms. This is in some sense also a "Flink as a Library" deployment, but with selective (fewer) dependencies. The RocksDB issue applies only to this problem here.
    
    To make this simpler for the users, it would be great to have not N different models that we talk about, but ideally only two: **Framework Style** and **Library Style**. We could for example start to advocate and document that users should always use `flink-dist` as their standard dependency - "provided" in the framework style deployment, "compile" in the library style deployment. That might be a really easy way to work with that. The only problem for the time being is that `flink-dist` is quite big and contains for example also optional dependencies like `flink-table`, which makes it more hwavyweight for quickstarts. Maybe we can accept that as a tradeoff for dependency simplicity.


---

[GitHub] flink issue #5303: [hotfix][docs] Adjust RocksDb dependency docs

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5303
  
    Sounds good. Just to be sure: My write-up above was meant as a suggestion or food-for-thought, not as a final decision ;-)
    
    We should probably bring these thoughts to a dev discussion and get more opinions on that matter, because I think this is going to be a pretty fundamental thing in the future.


---

[GitHub] flink issue #5303: [hotfix][docs] Adjust RocksDb dependency docs

[zentol <gi...@git.apache.org>]

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5303
  
    see https://issues.apache.org/jira/browse/FLINK-8444


---

[GitHub] flink pull request #5303: [hotfix][docs] Adjust RocksDb dependency docs

[zentol <gi...@git.apache.org>]

Github user zentol closed the pull request at:

    https://github.com/apache/flink/pull/5303


---