You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Varun Thacker (JIRA)" <ji...@apache.org> on 2016/03/07 08:43:40 UTC

[jira] [Created] (SOLR-8794) Remove code usage of previously removed solr.xml tags

Varun Thacker created SOLR-8794:
-----------------------------------

             Summary: Remove code usage of previously removed solr.xml tags
                 Key: SOLR-8794
                 URL: https://issues.apache.org/jira/browse/SOLR-8794
             Project: Solr
          Issue Type: Improvement
            Reporter: Varun Thacker
            Priority: Minor


If my reading of the code is correct any usage of {{solr/sharedLib}} ,{{solr/coreLoadThreads}} , {{solr/persistent}} and {{solr/zkHost}} in the solr.xml file will throw an error currently.

This is ensured using this code block in SolrXmlConfig.java

{code}
    failIfFound(config, "solr/@coreLoadThreads");
    failIfFound(config, "solr/@persistent");
    failIfFound(config, "solr/@sharedLib");
    failIfFound(config, "solr/@zkHost");
{code}

In the same class however , these properties are read. For example,

{code}
        case "sharedLib":
          builder.setSharedLibDirectory(value);
          break;
{code}

This should be redundant and I think we can remove them. More importantly we should remove usage of it from the wiki page ( https://cwiki.apache.org/confluence/display/solr/Format+of+solr.xml )

Also does anyone know if keeping {[managementPath}} is useful for the future? The wiki's description for it is "Currently non-operational."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: [jira] [Created] (SOLR-8794) Remove code usage of previously removed solr.xml tags

Posted by Erick Erickson <er...@gmail.com>.
Right, the failIfFound stuff was only for when we were supporting both
formats. Now that we're not supporting the older format we should be able
to nuke any code that reads it. I suppose leaving the checks in is a good
idea though.

+1 for updating the docs.
On Mar 6, 2016 11:43 PM, "Varun Thacker (JIRA)" <ji...@apache.org> wrote:

> Varun Thacker created SOLR-8794:
> -----------------------------------
>
>              Summary: Remove code usage of previously removed solr.xml tags
>                  Key: SOLR-8794
>                  URL: https://issues.apache.org/jira/browse/SOLR-8794
>              Project: Solr
>           Issue Type: Improvement
>             Reporter: Varun Thacker
>             Priority: Minor
>
>
> If my reading of the code is correct any usage of {{solr/sharedLib}}
> ,{{solr/coreLoadThreads}} , {{solr/persistent}} and {{solr/zkHost}} in the
> solr.xml file will throw an error currently.
>
> This is ensured using this code block in SolrXmlConfig.java
>
> {code}
>     failIfFound(config, "solr/@coreLoadThreads");
>     failIfFound(config, "solr/@persistent");
>     failIfFound(config, "solr/@sharedLib");
>     failIfFound(config, "solr/@zkHost");
> {code}
>
> In the same class however , these properties are read. For example,
>
> {code}
>         case "sharedLib":
>           builder.setSharedLibDirectory(value);
>           break;
> {code}
>
> This should be redundant and I think we can remove them. More importantly
> we should remove usage of it from the wiki page (
> https://cwiki.apache.org/confluence/display/solr/Format+of+solr.xml )
>
> Also does anyone know if keeping {[managementPath}} is useful for the
> future? The wiki's description for it is "Currently non-operational."
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>