[GitHub] [spark] grundprinzip commented on a diff in pull request #38310: [SPARK-40839][CONNECT][PYTHON] Implement `DataFrame.sample`

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38310:
URL: https://github.com/apache/spark/pull/38310#discussion_r1000162117


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -192,5 +192,9 @@ message Sample {
   double lower_bound = 2;
   double upper_bound = 3;
   bool with_replacement = 4;
-  int64 seed = 5;
+  Seed seed = 5;
+}
+
+message Seed {

Review Comment:
   This is not true. The has* messages are generated for non simple types. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org