svn commit: r171140 - in /httpd/apreq/trunk: CHANGES glue/perl/lib/Apache2/Cookie.pm

[jo...@apache.org]

Author: joes
Date: Fri May 20 10:47:06 2005
New Revision: 171140

URL: http://svn.apache.org/viewcvs?rev=171140&view=rev
Log:
The VALUE_CLASS option died with 2.05-dev.

Modified:
    httpd/apreq/trunk/CHANGES
    httpd/apreq/trunk/glue/perl/lib/Apache2/Cookie.pm

Modified: httpd/apreq/trunk/CHANGES
URL: http://svn.apache.org/viewcvs/httpd/apreq/trunk/CHANGES?rev=171140&r1=171139&r2=171140&view=diff
==============================================================================
--- httpd/apreq/trunk/CHANGES (original)
+++ httpd/apreq/trunk/CHANGES Fri May 20 10:47:06 2005
@@ -6,6 +6,12 @@
 
 
 - Perl API [joes]
+  Drop support for Apache2::Cookie::Jar::new's VALUE_CLASS.
+  2.05-dev broke that API, and it's not worth trying to fix.
+  People who need that should use APR::Request::Cookie::Table's
+  cookie_class() API instead.
+
+- Perl API [joes]
   Fix cookie domain/path munging in Apache2::Cookie::new().
 
 

Modified: httpd/apreq/trunk/glue/perl/lib/Apache2/Cookie.pm
URL: http://svn.apache.org/viewcvs/httpd/apreq/trunk/glue/perl/lib/Apache2/Cookie.pm?rev=171140&r1=171139&r2=171140&view=diff
==============================================================================
--- httpd/apreq/trunk/glue/perl/lib/Apache2/Cookie.pm (original)
+++ httpd/apreq/trunk/glue/perl/lib/Apache2/Cookie.pm Fri May 20 10:47:06 2005
@@ -183,36 +183,10 @@
 
 =head2 new
 
-    Apache2::Cookie::Jar->new($env, %args)
+    Apache2::Cookie::Jar->new($env)
 
 Class method that retrieves the parsed cookie jar from the current 
-environment.  An optional VALUE_CLASS => $class argument instructs
-the jar to bless any returned cookies into $class instead
-of Apache2::Cookie.  This feature is meant to be useful in situations 
-where C<Apache2::Cookie::thaw()> is unable to correctly interpret an incoming
-cookie's serialization.  Users can simply override C<thaw> in an
-application-specific subclass and pass that subclass's name as the 
-VALUE_CLASS argument:
-
-=for example begin
-
-    {
-        package FOO;
-        @ISA= 'Apache2::Cookie';
-    }
-    my $jar = Apache2::Cookie::Jar->new($r, VALUE_CLASS => "FOO");
-    ok $jar->cookies("foo")->isa("FOO");
-    ok $jar->cookies->{bar}->isa("FOO");
-
-=for example end
-
-=for example_testing
-    ok $jar->isa("Apache2::Cookie::Jar");
-    $jar->cookies->do(sub { ok $_[1]->isa("FOO"); });
-    map { ok $_->isa("FOO") } values %{$jar->cookies};
-
-
-
+environment.
 
 =head2 cookies