You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2023/02/02 16:03:38 UTC

[GitHub] [lucene] rmuir commented on issue #12115: org.apache.lucene.search.uhighlight.TestUnifiedHighlighterTermVec.testFetchTermVecsOncePerDoc fails reproducibly

rmuir commented on issue #12115:
URL: https://github.com/apache/lucene/issues/12115#issuecomment-1413981821

   I think @romseygeek explanation makes sense. Wrapping the reader is not helpful to testing that the highlighter uses it correctly, it just causes complexity?
   
   To me the easiest fix would be to remove the `callStackContains(ParallelLeafReader) stuff from the `AssertOnceTermVecDirectoryReader`, and to replace `newSearcher(ir);` with `newSearcher(ir, false); // don't wrap the reader with Parallel or other wrappers in this test`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org