[GitHub] [beam] ahmedabu98 commented on a diff in pull request #25240: Add partitioned reads to JDBC SchemaIO

["ahmedabu98 (via GitHub)" <gi...@apache.org>]

ahmedabu98 commented on code in PR #25240:
URL: https://github.com/apache/beam/pull/25240#discussion_r1092561215


##########
sdks/python/apache_beam/io/jdbc.py:
##########
@@ -125,6 +125,9 @@ def default_io_expansion_service(classpath=None):
         ('fetch_size', typing.Optional[int]),
         ('output_parallelization', typing.Optional[bool]),
         ('autosharding', typing.Optional[bool]),
+        ('partitionColumn', typing.Optional[str]),
+        ('tableName', typing.Optional[str]),

Review Comment:
   Was the `tableName` configuration field meant to be added?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org