[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #67: include hpack details in license

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko-http/pull/67#discussion_r1111043163


##########
project/AddMetaInfLicenseFiles.scala:
##########
@@ -17,9 +17,18 @@ import org.mdedetrich.apache.sonatype.SonatypeApachePlugin.autoImport._
  */
 object AddMetaInfLicenseFiles extends AutoPlugin {
 
+  private lazy val baseDir = LocalRootProject / baseDirectory
+
   override lazy val projectSettings = Seq(
+    apacheSonatypeLicenseFile := baseDir.value / "legal" / "StandardLicense.txt",
     apacheSonatypeDisclaimerFile := Some((LocalRootProject / baseDirectory).value / "DISCLAIMER"))
 
+  /**
+   * Settings specific for Pekko http-core subproject which require a different license file.
+   */
+  lazy val httpCoreSettings = Seq(
+    apacheSonatypeLicenseFile := baseDir.value / "LICENSE")

Review Comment:
   This is the correct way of doing it because of how its structured for sbt-apache-sonatype and there is a test for it (see https://github.com/mdedetrich/sbt-apache-sonatype/tree/main/src/sbt-test/sbt-apache-sonatype/multi-project-different-license-test).
   
   sbt-apache-sonatype is designed to set `apacheSonatypeLicenseFile` for every project and then a user is meant to override that value on a per project basis. Unless there is some non-determinism I am not aware of it should work fine (and can be verified with `show apacheSonatypeLicenseFile`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org