You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2022/02/01 10:34:00 UTC

[jira] [Created] (YUNIKORN-1067) standardise on formatMetricName() call

Wilfred Spiegelenburg created YUNIKORN-1067:
-----------------------------------------------

             Summary: standardise on formatMetricName() call
                 Key: YUNIKORN-1067
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1067
             Project: Apache YuniKorn
          Issue Type: Improvement
          Components: core - common
            Reporter: Wilfred Spiegelenburg


In the metrics code we have two functions to remove special characters from metrics names. We should only have one.

The {{QueueMetrics.substituteQueueName(queueName string)}} should be replaced with the generic {{formatMetricName(metricname string)}} function.

When we do that we should also make sure that in the QueueMetrics we only call the function once and not twice (lines 44 + 52)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org