[I] Refactor `listTemplates` and `listIsos` workflows [cloudstack]

["bernardodemarco (via GitHub)" <gi...@apache.org>]

bernardodemarco opened a new issue, #11209:
URL: https://github.com/apache/cloudstack/issues/11209

   The workflows of the `listIsos` and `listTemplates` APIs, particularly the `com.cloud.api.query.QueryManagerImpl#searchForTemplatesInternal` method, could greatly benefit from refactoring.
   
   This method accepts over 20 parameters, spans approximately 200 lines, performs DAO operations directly from the business/service layer, and lacks modularization, logging, and unit tests. These issues make troubleshooting and maintenance challenging.
   
   https://github.com/apache/cloudstack/blob/f52e05863e608f53f9e97e93fe47577b8dfe189b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L4802-L5007
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Refactor `listTemplates` and `listIsos` workflows [cloudstack]

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on issue #11209:
URL: https://github.com/apache/cloudstack/issues/11209#issuecomment-3077038469

   this is one of the methods that suffers this quality. I am now working on `listDataCentersInternal`. it fortunately takes the cmd object but is 200 lines as well. I am refactorring it to be able to troubleshoot. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org