You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 14:21:53 UTC

[GitHub] [arrow-rs] tustvold commented on pull request #2364: refactor: Make read_num_bytes a function instead of a macro

tustvold commented on PR #2364:
URL: https://github.com/apache/arrow-rs/pull/2364#issuecomment-1208196259

   Have you run the benchmarks to confirm this doesn't adversely impact performance? LLVM tends to be pretty pessimistic about const inlining, and this can then prevent it eliminating bounds checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org