You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Michael Brohl <mi...@ecomify.de> on 2017/09/10 11:02:57 UTC
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
+1
Looking forward to the design proposal.
You can use the wiki with a new page under
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
to provide the details and support collaboration.
Thanks,
Michael
Am 26.08.17 um 13:31 schrieb Pritam Kute:
> Hi Devs,
>
> Many e-commerce businesses (especially operating in Asian countries)
> nowadays use short messaging service (SMS) in mobile phones to notify and
> update customers about order details, shipment statuses etc.
>
> I would like to propose an SMS Gateway Integration in Ofbiz. I will share
> proposed design details with you all soon. Till then, I would like to know
> your thoughts on this idea.
>
> Thanks and Regards
> --
> Pritam Kute
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Rishi Solanki <ri...@gmail.com>.
Thanks Pritam!!
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Sat, Nov 24, 2018 at 3:08 PM Pritam Kute <pr...@hotwaxsystems.com>
wrote:
> Thanks all for your inputs.
>
> I have updated the first pass of the implementation on the ticket [1].
>
> Request all to have a look and provide feedback.
>
> [1]: https://issues.apache.org/jira/browse/OFBIZ-10457
>
> Thanks
> --
> Pritam Kute
>
> On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin <ni...@nereide.fr>
> wrote:
>
> > Hello Pritam,
> >
> > Maybe I arrived after the war still I wish sharing my opinion :)
> >
> > General term Sms seems to be too specific, I would've oriented on
> > TelecomGateway
> >
> > * ProductStoreTelecomGatewaySetting (too long :))
> > * TelecomGatewayConfig
> > * TelecomGatewayConfigType, and so on
> >
> > For the attributes :
> > * configId is too generic and already use on productConfig entity. It's
> > preferable to have unique name in OFBiz as primaryKey (same for
> settingId)
> > * parentSmsConfigTypeId need to rename on parentTypeId if you want to
> > follow EntityType pattern.
> >
> > Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> > ProductStoreSmsSetting where the template application will be done ?
> >
> > What do you imagine behind the CustomMethod linked to SmsTemplateSetting
> ?
> >
> > That's all I'll stop bothering you :)
> >
> > Cheers,
> >
> > Nicolas
> >
> > On 02/07/2018 11:22, Pritam Kute wrote:
> > > Hello Devs,
> > >
> > > Sorry for such a long delay.
> > >
> > > Thanks, Michael for your inputs. I have added design proposal for the
> SMS
> > > gateway integration and can be accessed here
> > > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > > https://cwiki.apache.org/confluence/x/Zgo0BQ
> > >
> > > Please go through the design and let me know if there are any
> questions,
> > > suggestions or improvements which we can do.
> > >
> > > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with
> the
> > > design and documentation.
> > >
> > > Thanks and Regards
> > > --
> > > Pritam Kute
> > >
> > > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <
> michael.brohl@ecomify.de>
> > > wrote:
> > >
> > >> +1
> > >>
> > >> Looking forward to the design proposal.
> > >>
> > >> You can use the wiki with a new page under
> > >>
> > >>
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> > >> to provide the details and support collaboration.
> > >>
> > >> Thanks,
> > >>
> > >> Michael
> > >>
> > >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > >>> Hi Devs,
> > >>>
> > >>> Many e-commerce businesses (especially operating in Asian countries)
> > >>> nowadays use short messaging service (SMS) in mobile phones to notify
> > and
> > >>> update customers about order details, shipment statuses etc.
> > >>>
> > >>> I would like to propose an SMS Gateway Integration in Ofbiz. I will
> > share
> > >>> proposed design details with you all soon. Till then, I would like to
> > >> know
> > >>> your thoughts on this idea.
> > >>>
> > >>> Thanks and Regards
> > >>> --
> > >>> Pritam Kute
> > >>>
> > >>
> > >>
> >
> >
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Pritam Kute <pr...@hotwaxsystems.com>.
Hello Scott,
Thanks for your comment. The proposal was just to integrate the Short
Messaging Service only. So we had given a specific name to the entity. As
per the suggestions from the community, we renamed it as telecom instead of
SMS so it's somewhat a broader term than the old one. We have designed it
in a similar way like the payment gateway integration in OFBiz. As per
design, it can be used for all types of telecom communications like SMS,
MMS, WhatsApp, OTP generation and verification etc.
Your suggestion looks very good to me but for now, we are not aware of how
much changes/improvements we would need to make existing codebase to
accommodate Email and telecom services using a single entity. We will keep
this pointer in mind and we can work on it as a part of design improvements.
Thanks
--
Pritam Kute
On Mon, Nov 26, 2018 at 2:56 AM Scott Gray <sc...@hotwaxsystems.com>
wrote:
> One thing to consider, is it better to have a single table for configuring
> communication content generation or multiple?
>
> i.e. would it be better to have a single ProductStoreCommunicationSetting
> table instead of ProductStoreEmailSetting and ProductStoreSmsSetting (or
> whatever name has been decided).
>
> I don't have a design to propose and haven't read the design for SMS, but I
> noticed the table name debate in this thread and it led me to asking the
> question.
>
> Regards
> Scott
>
> On Mon, 26 Nov 2018 at 03:50, Pritam Kute <pr...@hotwaxsystems.com>
> wrote:
>
> > Thanks Pierre and Rishi.
> >
> > Let's wait for some more days to listen to the feedback from the
> community
> > as it is the first pass of the feature. As per feedback, we can do the
> > final improvements and then we can decide how to make it available for
> the
> > community as early as possible.
> >
> > Thanks and Regards
> > --
> > Pritam Kute
> >
> >
> > On Sat, Nov 24, 2018 at 7:23 PM Pierre Smits <pi...@apache.org>
> > wrote:
> >
> > > Hi Pritam,
> > >
> > > Thank you for your initiative to enhance OFBiz with a new pluggable
> > > feature. Is there somewhere a Git or SVN repo where the code can be
> > pulled
> > > from? It might take a long time before this will be part of the code
> > base,
> > > and (potential) OFBiz adopters might miss (or forget) all the
> activities
> > in
> > > JIRA or postings in MLs.
> > >
> > > Best regards,
> > >
> > > Pierre Smits
> > >
> > > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > > *Apache Directory <https://directory.apache.org>, PMC Member*
> > > Apache Incubator <https://incubator.apache.org>, committer
> > > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> > privileges)
> > > since 2008*
> > > Apache Steve <https://steve.apache.org>, committer
> > >
> > >
> > > On Sat, Nov 24, 2018 at 10:38 AM Pritam Kute <
> > > pritam.kute@hotwaxsystems.com>
> > > wrote:
> > >
> > > > Thanks all for your inputs.
> > > >
> > > > I have updated the first pass of the implementation on the ticket
> [1].
> > > >
> > > > Request all to have a look and provide feedback.
> > > >
> > > > [1]: https://issues.apache.org/jira/browse/OFBIZ-10457
> > > >
> > > > Thanks
> > > > --
> > > > Pritam Kute
> > > >
> > > > On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin <
> > nicolas.malin@nereide.fr>
> > > > wrote:
> > > >
> > > > > Hello Pritam,
> > > > >
> > > > > Maybe I arrived after the war still I wish sharing my opinion :)
> > > > >
> > > > > General term Sms seems to be too specific, I would've oriented on
> > > > > TelecomGateway
> > > > >
> > > > > * ProductStoreTelecomGatewaySetting (too long :))
> > > > > * TelecomGatewayConfig
> > > > > * TelecomGatewayConfigType, and so on
> > > > >
> > > > > For the attributes :
> > > > > * configId is too generic and already use on productConfig entity.
> > It's
> > > > > preferable to have unique name in OFBiz as primaryKey (same for
> > > > settingId)
> > > > > * parentSmsConfigTypeId need to rename on parentTypeId if you want
> to
> > > > > follow EntityType pattern.
> > > > >
> > > > > Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> > > > > ProductStoreSmsSetting where the template application will be done
> ?
> > > > >
> > > > > What do you imagine behind the CustomMethod linked to
> > > SmsTemplateSetting
> > > > ?
> > > > >
> > > > > That's all I'll stop bothering you :)
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Nicolas
> > > > >
> > > > > On 02/07/2018 11:22, Pritam Kute wrote:
> > > > > > Hello Devs,
> > > > > >
> > > > > > Sorry for such a long delay.
> > > > > >
> > > > > > Thanks, Michael for your inputs. I have added design proposal for
> > the
> > > > SMS
> > > > > > gateway integration and can be accessed here
> > > > > > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > > > > > https://cwiki.apache.org/confluence/x/Zgo0BQ
> > > > > >
> > > > > > Please go through the design and let me know if there are any
> > > > questions,
> > > > > > suggestions or improvements which we can do.
> > > > > >
> > > > > > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me
> > with
> > > > the
> > > > > > design and documentation.
> > > > > >
> > > > > > Thanks and Regards
> > > > > > --
> > > > > > Pritam Kute
> > > > > >
> > > > > > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <
> > > > michael.brohl@ecomify.de>
> > > > > > wrote:
> > > > > >
> > > > > >> +1
> > > > > >>
> > > > > >> Looking forward to the design proposal.
> > > > > >>
> > > > > >> You can use the wiki with a new page under
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> > > > > >> to provide the details and support collaboration.
> > > > > >>
> > > > > >> Thanks,
> > > > > >>
> > > > > >> Michael
> > > > > >>
> > > > > >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > > > > >>> Hi Devs,
> > > > > >>>
> > > > > >>> Many e-commerce businesses (especially operating in Asian
> > > countries)
> > > > > >>> nowadays use short messaging service (SMS) in mobile phones to
> > > notify
> > > > > and
> > > > > >>> update customers about order details, shipment statuses etc.
> > > > > >>>
> > > > > >>> I would like to propose an SMS Gateway Integration in Ofbiz. I
> > will
> > > > > share
> > > > > >>> proposed design details with you all soon. Till then, I would
> > like
> > > to
> > > > > >> know
> > > > > >>> your thoughts on this idea.
> > > > > >>>
> > > > > >>> Thanks and Regards
> > > > > >>> --
> > > > > >>> Pritam Kute
> > > > > >>>
> > > > > >>
> > > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Scott Gray <sc...@hotwaxsystems.com>.
One thing to consider, is it better to have a single table for configuring
communication content generation or multiple?
i.e. would it be better to have a single ProductStoreCommunicationSetting
table instead of ProductStoreEmailSetting and ProductStoreSmsSetting (or
whatever name has been decided).
I don't have a design to propose and haven't read the design for SMS, but I
noticed the table name debate in this thread and it led me to asking the
question.
Regards
Scott
On Mon, 26 Nov 2018 at 03:50, Pritam Kute <pr...@hotwaxsystems.com>
wrote:
> Thanks Pierre and Rishi.
>
> Let's wait for some more days to listen to the feedback from the community
> as it is the first pass of the feature. As per feedback, we can do the
> final improvements and then we can decide how to make it available for the
> community as early as possible.
>
> Thanks and Regards
> --
> Pritam Kute
>
>
> On Sat, Nov 24, 2018 at 7:23 PM Pierre Smits <pi...@apache.org>
> wrote:
>
> > Hi Pritam,
> >
> > Thank you for your initiative to enhance OFBiz with a new pluggable
> > feature. Is there somewhere a Git or SVN repo where the code can be
> pulled
> > from? It might take a long time before this will be part of the code
> base,
> > and (potential) OFBiz adopters might miss (or forget) all the activities
> in
> > JIRA or postings in MLs.
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> > Apache Incubator <https://incubator.apache.org>, committer
> > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> > since 2008*
> > Apache Steve <https://steve.apache.org>, committer
> >
> >
> > On Sat, Nov 24, 2018 at 10:38 AM Pritam Kute <
> > pritam.kute@hotwaxsystems.com>
> > wrote:
> >
> > > Thanks all for your inputs.
> > >
> > > I have updated the first pass of the implementation on the ticket [1].
> > >
> > > Request all to have a look and provide feedback.
> > >
> > > [1]: https://issues.apache.org/jira/browse/OFBIZ-10457
> > >
> > > Thanks
> > > --
> > > Pritam Kute
> > >
> > > On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin <
> nicolas.malin@nereide.fr>
> > > wrote:
> > >
> > > > Hello Pritam,
> > > >
> > > > Maybe I arrived after the war still I wish sharing my opinion :)
> > > >
> > > > General term Sms seems to be too specific, I would've oriented on
> > > > TelecomGateway
> > > >
> > > > * ProductStoreTelecomGatewaySetting (too long :))
> > > > * TelecomGatewayConfig
> > > > * TelecomGatewayConfigType, and so on
> > > >
> > > > For the attributes :
> > > > * configId is too generic and already use on productConfig entity.
> It's
> > > > preferable to have unique name in OFBiz as primaryKey (same for
> > > settingId)
> > > > * parentSmsConfigTypeId need to rename on parentTypeId if you want to
> > > > follow EntityType pattern.
> > > >
> > > > Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> > > > ProductStoreSmsSetting where the template application will be done ?
> > > >
> > > > What do you imagine behind the CustomMethod linked to
> > SmsTemplateSetting
> > > ?
> > > >
> > > > That's all I'll stop bothering you :)
> > > >
> > > > Cheers,
> > > >
> > > > Nicolas
> > > >
> > > > On 02/07/2018 11:22, Pritam Kute wrote:
> > > > > Hello Devs,
> > > > >
> > > > > Sorry for such a long delay.
> > > > >
> > > > > Thanks, Michael for your inputs. I have added design proposal for
> the
> > > SMS
> > > > > gateway integration and can be accessed here
> > > > > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > > > > https://cwiki.apache.org/confluence/x/Zgo0BQ
> > > > >
> > > > > Please go through the design and let me know if there are any
> > > questions,
> > > > > suggestions or improvements which we can do.
> > > > >
> > > > > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me
> with
> > > the
> > > > > design and documentation.
> > > > >
> > > > > Thanks and Regards
> > > > > --
> > > > > Pritam Kute
> > > > >
> > > > > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <
> > > michael.brohl@ecomify.de>
> > > > > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> Looking forward to the design proposal.
> > > > >>
> > > > >> You can use the wiki with a new page under
> > > > >>
> > > > >>
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> > > > >> to provide the details and support collaboration.
> > > > >>
> > > > >> Thanks,
> > > > >>
> > > > >> Michael
> > > > >>
> > > > >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > > > >>> Hi Devs,
> > > > >>>
> > > > >>> Many e-commerce businesses (especially operating in Asian
> > countries)
> > > > >>> nowadays use short messaging service (SMS) in mobile phones to
> > notify
> > > > and
> > > > >>> update customers about order details, shipment statuses etc.
> > > > >>>
> > > > >>> I would like to propose an SMS Gateway Integration in Ofbiz. I
> will
> > > > share
> > > > >>> proposed design details with you all soon. Till then, I would
> like
> > to
> > > > >> know
> > > > >>> your thoughts on this idea.
> > > > >>>
> > > > >>> Thanks and Regards
> > > > >>> --
> > > > >>> Pritam Kute
> > > > >>>
> > > > >>
> > > > >>
> > > >
> > > >
> > >
> >
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Pritam Kute <pr...@hotwaxsystems.com>.
Thanks Pierre and Rishi.
Let's wait for some more days to listen to the feedback from the community
as it is the first pass of the feature. As per feedback, we can do the
final improvements and then we can decide how to make it available for the
community as early as possible.
Thanks and Regards
--
Pritam Kute
On Sat, Nov 24, 2018 at 7:23 PM Pierre Smits <pi...@apache.org> wrote:
> Hi Pritam,
>
> Thank you for your initiative to enhance OFBiz with a new pluggable
> feature. Is there somewhere a Git or SVN repo where the code can be pulled
> from? It might take a long time before this will be part of the code base,
> and (potential) OFBiz adopters might miss (or forget) all the activities in
> JIRA or postings in MLs.
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Sat, Nov 24, 2018 at 10:38 AM Pritam Kute <
> pritam.kute@hotwaxsystems.com>
> wrote:
>
> > Thanks all for your inputs.
> >
> > I have updated the first pass of the implementation on the ticket [1].
> >
> > Request all to have a look and provide feedback.
> >
> > [1]: https://issues.apache.org/jira/browse/OFBIZ-10457
> >
> > Thanks
> > --
> > Pritam Kute
> >
> > On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin <ni...@nereide.fr>
> > wrote:
> >
> > > Hello Pritam,
> > >
> > > Maybe I arrived after the war still I wish sharing my opinion :)
> > >
> > > General term Sms seems to be too specific, I would've oriented on
> > > TelecomGateway
> > >
> > > * ProductStoreTelecomGatewaySetting (too long :))
> > > * TelecomGatewayConfig
> > > * TelecomGatewayConfigType, and so on
> > >
> > > For the attributes :
> > > * configId is too generic and already use on productConfig entity. It's
> > > preferable to have unique name in OFBiz as primaryKey (same for
> > settingId)
> > > * parentSmsConfigTypeId need to rename on parentTypeId if you want to
> > > follow EntityType pattern.
> > >
> > > Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> > > ProductStoreSmsSetting where the template application will be done ?
> > >
> > > What do you imagine behind the CustomMethod linked to
> SmsTemplateSetting
> > ?
> > >
> > > That's all I'll stop bothering you :)
> > >
> > > Cheers,
> > >
> > > Nicolas
> > >
> > > On 02/07/2018 11:22, Pritam Kute wrote:
> > > > Hello Devs,
> > > >
> > > > Sorry for such a long delay.
> > > >
> > > > Thanks, Michael for your inputs. I have added design proposal for the
> > SMS
> > > > gateway integration and can be accessed here
> > > > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > > > https://cwiki.apache.org/confluence/x/Zgo0BQ
> > > >
> > > > Please go through the design and let me know if there are any
> > questions,
> > > > suggestions or improvements which we can do.
> > > >
> > > > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with
> > the
> > > > design and documentation.
> > > >
> > > > Thanks and Regards
> > > > --
> > > > Pritam Kute
> > > >
> > > > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <
> > michael.brohl@ecomify.de>
> > > > wrote:
> > > >
> > > >> +1
> > > >>
> > > >> Looking forward to the design proposal.
> > > >>
> > > >> You can use the wiki with a new page under
> > > >>
> > > >>
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> > > >> to provide the details and support collaboration.
> > > >>
> > > >> Thanks,
> > > >>
> > > >> Michael
> > > >>
> > > >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > > >>> Hi Devs,
> > > >>>
> > > >>> Many e-commerce businesses (especially operating in Asian
> countries)
> > > >>> nowadays use short messaging service (SMS) in mobile phones to
> notify
> > > and
> > > >>> update customers about order details, shipment statuses etc.
> > > >>>
> > > >>> I would like to propose an SMS Gateway Integration in Ofbiz. I will
> > > share
> > > >>> proposed design details with you all soon. Till then, I would like
> to
> > > >> know
> > > >>> your thoughts on this idea.
> > > >>>
> > > >>> Thanks and Regards
> > > >>> --
> > > >>> Pritam Kute
> > > >>>
> > > >>
> > > >>
> > >
> > >
> >
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Pierre Smits <pi...@apache.org>.
Hi Pritam,
Thank you for your initiative to enhance OFBiz with a new pluggable
feature. Is there somewhere a Git or SVN repo where the code can be pulled
from? It might take a long time before this will be part of the code base,
and (potential) OFBiz adopters might miss (or forget) all the activities in
JIRA or postings in MLs.
Best regards,
Pierre Smits
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer
On Sat, Nov 24, 2018 at 10:38 AM Pritam Kute <pr...@hotwaxsystems.com>
wrote:
> Thanks all for your inputs.
>
> I have updated the first pass of the implementation on the ticket [1].
>
> Request all to have a look and provide feedback.
>
> [1]: https://issues.apache.org/jira/browse/OFBIZ-10457
>
> Thanks
> --
> Pritam Kute
>
> On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin <ni...@nereide.fr>
> wrote:
>
> > Hello Pritam,
> >
> > Maybe I arrived after the war still I wish sharing my opinion :)
> >
> > General term Sms seems to be too specific, I would've oriented on
> > TelecomGateway
> >
> > * ProductStoreTelecomGatewaySetting (too long :))
> > * TelecomGatewayConfig
> > * TelecomGatewayConfigType, and so on
> >
> > For the attributes :
> > * configId is too generic and already use on productConfig entity. It's
> > preferable to have unique name in OFBiz as primaryKey (same for
> settingId)
> > * parentSmsConfigTypeId need to rename on parentTypeId if you want to
> > follow EntityType pattern.
> >
> > Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> > ProductStoreSmsSetting where the template application will be done ?
> >
> > What do you imagine behind the CustomMethod linked to SmsTemplateSetting
> ?
> >
> > That's all I'll stop bothering you :)
> >
> > Cheers,
> >
> > Nicolas
> >
> > On 02/07/2018 11:22, Pritam Kute wrote:
> > > Hello Devs,
> > >
> > > Sorry for such a long delay.
> > >
> > > Thanks, Michael for your inputs. I have added design proposal for the
> SMS
> > > gateway integration and can be accessed here
> > > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > > https://cwiki.apache.org/confluence/x/Zgo0BQ
> > >
> > > Please go through the design and let me know if there are any
> questions,
> > > suggestions or improvements which we can do.
> > >
> > > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with
> the
> > > design and documentation.
> > >
> > > Thanks and Regards
> > > --
> > > Pritam Kute
> > >
> > > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <
> michael.brohl@ecomify.de>
> > > wrote:
> > >
> > >> +1
> > >>
> > >> Looking forward to the design proposal.
> > >>
> > >> You can use the wiki with a new page under
> > >>
> > >>
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> > >> to provide the details and support collaboration.
> > >>
> > >> Thanks,
> > >>
> > >> Michael
> > >>
> > >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > >>> Hi Devs,
> > >>>
> > >>> Many e-commerce businesses (especially operating in Asian countries)
> > >>> nowadays use short messaging service (SMS) in mobile phones to notify
> > and
> > >>> update customers about order details, shipment statuses etc.
> > >>>
> > >>> I would like to propose an SMS Gateway Integration in Ofbiz. I will
> > share
> > >>> proposed design details with you all soon. Till then, I would like to
> > >> know
> > >>> your thoughts on this idea.
> > >>>
> > >>> Thanks and Regards
> > >>> --
> > >>> Pritam Kute
> > >>>
> > >>
> > >>
> >
> >
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Pritam Kute <pr...@hotwaxsystems.com>.
Thanks all for your inputs.
I have updated the first pass of the implementation on the ticket [1].
Request all to have a look and provide feedback.
[1]: https://issues.apache.org/jira/browse/OFBIZ-10457
Thanks
--
Pritam Kute
On Fri, Aug 24, 2018 at 2:12 AM Nicolas Malin <ni...@nereide.fr>
wrote:
> Hello Pritam,
>
> Maybe I arrived after the war still I wish sharing my opinion :)
>
> General term Sms seems to be too specific, I would've oriented on
> TelecomGateway
>
> * ProductStoreTelecomGatewaySetting (too long :))
> * TelecomGatewayConfig
> * TelecomGatewayConfigType, and so on
>
> For the attributes :
> * configId is too generic and already use on productConfig entity. It's
> preferable to have unique name in OFBiz as primaryKey (same for settingId)
> * parentSmsConfigTypeId need to rename on parentTypeId if you want to
> follow EntityType pattern.
>
> Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
> ProductStoreSmsSetting where the template application will be done ?
>
> What do you imagine behind the CustomMethod linked to SmsTemplateSetting ?
>
> That's all I'll stop bothering you :)
>
> Cheers,
>
> Nicolas
>
> On 02/07/2018 11:22, Pritam Kute wrote:
> > Hello Devs,
> >
> > Sorry for such a long delay.
> >
> > Thanks, Michael for your inputs. I have added design proposal for the SMS
> > gateway integration and can be accessed here
> > <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> > https://cwiki.apache.org/confluence/x/Zgo0BQ
> >
> > Please go through the design and let me know if there are any questions,
> > suggestions or improvements which we can do.
> >
> > Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
> > design and documentation.
> >
> > Thanks and Regards
> > --
> > Pritam Kute
> >
> > On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <mi...@ecomify.de>
> > wrote:
> >
> >> +1
> >>
> >> Looking forward to the design proposal.
> >>
> >> You can use the wiki with a new page under
> >>
> >>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> >> to provide the details and support collaboration.
> >>
> >> Thanks,
> >>
> >> Michael
> >>
> >> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> >>> Hi Devs,
> >>>
> >>> Many e-commerce businesses (especially operating in Asian countries)
> >>> nowadays use short messaging service (SMS) in mobile phones to notify
> and
> >>> update customers about order details, shipment statuses etc.
> >>>
> >>> I would like to propose an SMS Gateway Integration in Ofbiz. I will
> share
> >>> proposed design details with you all soon. Till then, I would like to
> >> know
> >>> your thoughts on this idea.
> >>>
> >>> Thanks and Regards
> >>> --
> >>> Pritam Kute
> >>>
> >>
> >>
>
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Nicolas Malin <ni...@nereide.fr>.
Hello Pritam,
Maybe I arrived after the war still I wish sharing my opinion :)
General term Sms seems to be too specific, I would've oriented on
TelecomGateway
* ProductStoreTelecomGatewaySetting (too long :))
* TelecomGatewayConfig
* TelecomGatewayConfigType, and so on
For the attributes :
* configId is too generic and already use on productConfig entity. It's
preferable to have unique name in OFBiz as primaryKey (same for settingId)
* parentSmsConfigTypeId need to rename on parentTypeId if you want to
follow EntityType pattern.
Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on
ProductStoreSmsSetting where the template application will be done ?
What do you imagine behind the CustomMethod linked to SmsTemplateSetting ?
That's all I'll stop bothering you :)
Cheers,
Nicolas
On 02/07/2018 11:22, Pritam Kute wrote:
> Hello Devs,
>
> Sorry for such a long delay.
>
> Thanks, Michael for your inputs. I have added design proposal for the SMS
> gateway integration and can be accessed here
> <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> https://cwiki.apache.org/confluence/x/Zgo0BQ
>
> Please go through the design and let me know if there are any questions,
> suggestions or improvements which we can do.
>
> Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
> design and documentation.
>
> Thanks and Regards
> --
> Pritam Kute
>
> On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <mi...@ecomify.de>
> wrote:
>
>> +1
>>
>> Looking forward to the design proposal.
>>
>> You can use the wiki with a new page under
>>
>> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
>> to provide the details and support collaboration.
>>
>> Thanks,
>>
>> Michael
>>
>> Am 26.08.17 um 13:31 schrieb Pritam Kute:
>>> Hi Devs,
>>>
>>> Many e-commerce businesses (especially operating in Asian countries)
>>> nowadays use short messaging service (SMS) in mobile phones to notify and
>>> update customers about order details, shipment statuses etc.
>>>
>>> I would like to propose an SMS Gateway Integration in Ofbiz. I will share
>>> proposed design details with you all soon. Till then, I would like to
>> know
>>> your thoughts on this idea.
>>>
>>> Thanks and Regards
>>> --
>>> Pritam Kute
>>>
>>
>>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Taher Alkhateeb <sl...@gmail.com>.
sounds awesome, and we could all benefit. +1
I propose preparing your PoC and sharing it here after you attaching
it in JIRA. I hope we can minimize the number of library dependencies
if we can.
On Tue, Jul 3, 2018 at 1:34 PM, Rishi Solanki <ri...@gmail.com> wrote:
> Pritam,
>
> Your proposal looks good to go with, only one point to discuss here;
> Like ProductStoreEmailSetting have all the configuration
> ProductStoreSmsSetting will have the settingId and all configuration goes
> into the SmsTemplateSetting. This looks okay to me, no objection. Do we
> have any recommendation to adopt such configuration so that not right now
> but in future we may opt one type setting for both Email and SMS.
>
> In that way we will have consistent design for both, and devs/users can
> easily grab such setting for their use.
>
>
>
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
> On Mon, Jul 2, 2018 at 2:52 PM, Pritam Kute <pr...@hotwaxsystems.com>
> wrote:
>
>> Hello Devs,
>>
>> Sorry for such a long delay.
>>
>> Thanks, Michael for your inputs. I have added design proposal for the SMS
>> gateway integration and can be accessed here
>> <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
>> https://cwiki.apache.org/confluence/x/Zgo0BQ
>>
>> Please go through the design and let me know if there are any questions,
>> suggestions or improvements which we can do.
>>
>> Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
>> design and documentation.
>>
>> Thanks and Regards
>> --
>> Pritam Kute
>>
>> On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <mi...@ecomify.de>
>> wrote:
>>
>> > +1
>> >
>> > Looking forward to the design proposal.
>> >
>> > You can use the wiki with a new page under
>> >
>> > https://cwiki.apache.org/confluence/display/OFBIZ/
>> OFBiz+Requirements+and+Design+Proposals
>> > to provide the details and support collaboration.
>> >
>> > Thanks,
>> >
>> > Michael
>> >
>> > Am 26.08.17 um 13:31 schrieb Pritam Kute:
>> > > Hi Devs,
>> > >
>> > > Many e-commerce businesses (especially operating in Asian countries)
>> > > nowadays use short messaging service (SMS) in mobile phones to notify
>> and
>> > > update customers about order details, shipment statuses etc.
>> > >
>> > > I would like to propose an SMS Gateway Integration in Ofbiz. I will
>> share
>> > > proposed design details with you all soon. Till then, I would like to
>> > know
>> > > your thoughts on this idea.
>> > >
>> > > Thanks and Regards
>> > > --
>> > > Pritam Kute
>> > >
>> >
>> >
>> >
>>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Rishi Solanki <ri...@gmail.com>.
Pritam,
Your proposal looks good to go with, only one point to discuss here;
Like ProductStoreEmailSetting have all the configuration
ProductStoreSmsSetting will have the settingId and all configuration goes
into the SmsTemplateSetting. This looks okay to me, no objection. Do we
have any recommendation to adopt such configuration so that not right now
but in future we may opt one type setting for both Email and SMS.
In that way we will have consistent design for both, and devs/users can
easily grab such setting for their use.
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Mon, Jul 2, 2018 at 2:52 PM, Pritam Kute <pr...@hotwaxsystems.com>
wrote:
> Hello Devs,
>
> Sorry for such a long delay.
>
> Thanks, Michael for your inputs. I have added design proposal for the SMS
> gateway integration and can be accessed here
> <https://cwiki.apache.org/confluence/x/Zgo0BQ>:
> https://cwiki.apache.org/confluence/x/Zgo0BQ
>
> Please go through the design and let me know if there are any questions,
> suggestions or improvements which we can do.
>
> Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
> design and documentation.
>
> Thanks and Regards
> --
> Pritam Kute
>
> On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <mi...@ecomify.de>
> wrote:
>
> > +1
> >
> > Looking forward to the design proposal.
> >
> > You can use the wiki with a new page under
> >
> > https://cwiki.apache.org/confluence/display/OFBIZ/
> OFBiz+Requirements+and+Design+Proposals
> > to provide the details and support collaboration.
> >
> > Thanks,
> >
> > Michael
> >
> > Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > > Hi Devs,
> > >
> > > Many e-commerce businesses (especially operating in Asian countries)
> > > nowadays use short messaging service (SMS) in mobile phones to notify
> and
> > > update customers about order details, shipment statuses etc.
> > >
> > > I would like to propose an SMS Gateway Integration in Ofbiz. I will
> share
> > > proposed design details with you all soon. Till then, I would like to
> > know
> > > your thoughts on this idea.
> > >
> > > Thanks and Regards
> > > --
> > > Pritam Kute
> > >
> >
> >
> >
>
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
Posted by Pritam Kute <pr...@hotwaxsystems.com>.
Hello Devs,
Sorry for such a long delay.
Thanks, Michael for your inputs. I have added design proposal for the SMS
gateway integration and can be accessed here
<https://cwiki.apache.org/confluence/x/Zgo0BQ>:
https://cwiki.apache.org/confluence/x/Zgo0BQ
Please go through the design and let me know if there are any questions,
suggestions or improvements which we can do.
Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
design and documentation.
Thanks and Regards
--
Pritam Kute
On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl <mi...@ecomify.de>
wrote:
> +1
>
> Looking forward to the design proposal.
>
> You can use the wiki with a new page under
>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
> to provide the details and support collaboration.
>
> Thanks,
>
> Michael
>
> Am 26.08.17 um 13:31 schrieb Pritam Kute:
> > Hi Devs,
> >
> > Many e-commerce businesses (especially operating in Asian countries)
> > nowadays use short messaging service (SMS) in mobile phones to notify and
> > update customers about order details, shipment statuses etc.
> >
> > I would like to propose an SMS Gateway Integration in Ofbiz. I will share
> > proposed design details with you all soon. Till then, I would like to
> know
> > your thoughts on this idea.
> >
> > Thanks and Regards
> > --
> > Pritam Kute
> >
>
>
>