You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2021/10/01 15:39:00 UTC

[jira] [Comment Edited] (CASSANDRA-17017) Add required -f / --force option to nodetool verify

    [ https://issues.apache.org/jira/browse/CASSANDRA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422887#comment-17422887 ] 

Josh McKenzie edited comment on CASSANDRA-17017 at 10/1/21, 3:38 PM:
---------------------------------------------------------------------

[PR|https://github.com/apache/cassandra/pull/1246]

Kicked off a slow burn of dtests on CI just in case any of them relied on verify somehow and I'm not seeing it by grepping.

[JDK8|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/99/workflows/487a4862-68b6-47f9-9690-ddfdbea69bf2]
 [JDK11|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/99/workflows/3b267582-d698-44b6-9231-9d4638423b8a]

(edit: updated test runs w/highres circle settings. Wasn't aware it'd just barf on default. /sigh)


was (Author: jmckenzie):
[PR|https://github.com/apache/cassandra/pull/1246]

Kicked off a slow burn of dtests on CI just in case any of them relied on verify somehow and I'm not seeing it by grepping.

[JDK8|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/96/workflows/7686b1fb-267a-464c-8f49-6de00dc8baea]
 [JDK11|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/96/workflows/8dbd2169-1147-4215-889e-3ef4071148d6]

> Add required -f / --force option to nodetool verify
> ---------------------------------------------------
>
>                 Key: CASSANDRA-17017
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17017
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Josh McKenzie
>            Assignee: Josh McKenzie
>            Priority: Normal
>
> nodetool verify has some pretty significant problems with it (see CASSANDRA-9947).
> Until such time as we do the heavy(er) lift to fix the command, we should make it harder for people to shoot themselves in the foot with it. Adding a required "-f" flag to it with a requisite "Do you really know what you're doing? Check out this JIRA first" seems like it'd be the right thing to do in the interim.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org