You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/12/29 07:37:37 UTC

[PR] [SPARK-46542][SQL] Remove the check for `c>=0` from `ExternalCatalogUtils#needsEscaping` as it is always true [spark]

LuciferYang opened a new pull request, #44533:
URL: https://github.com/apache/spark/pull/44533

   ### What changes were proposed in this pull request?
   This pr remove the check for `c>=0` from `ExternalCatalogUtils#needsEscaping` since it is always true due to the numerical range of the `Char` type in Scala being from 0 to 65,535.
   
   ### Why are the changes needed?
   Remove constant condition
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GitHub Actions
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46542][SQL] Remove the check for `c>=0` from `ExternalCatalogUtils#needsEscaping` as it is always true [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44533:
URL: https://github.com/apache/spark/pull/44533#issuecomment-1872416373

   Merged to master. Thank you, @LuciferYang .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46542][SQL] Remove the check for `c>=0` from `ExternalCatalogUtils#needsEscaping` as it is always true [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44533:
URL: https://github.com/apache/spark/pull/44533#issuecomment-1872454973

   Thanks @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46542][SQL] Remove the check for `c>=0` from `ExternalCatalogUtils#needsEscaping` as it is always true [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44533: [SPARK-46542][SQL] Remove the check for `c>=0` from `ExternalCatalogUtils#needsEscaping` as it is always true
URL: https://github.com/apache/spark/pull/44533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org