You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mikemccand (via GitHub)" <gi...@apache.org> on 2023/12/12 11:40:07 UTC
[PR] #12911: regenerate binary FSTs for Nori and Kuromoji dictionaries to match current FST format [lucene]
mikemccand opened a new pull request, #12924:
URL: https://github.com/apache/lucene/pull/12924
This is the result of top-level `./gradlew regenerate` to rewrite all generated stuff in our source tree. The only resulting `git diff` were the Nori and Kuromoji FST dictionaries.
Note that I had to use OpenJDK 21 to do this. When I tried with JDK 17 (`openjdk full version "17.0.9+8"`) I hit these spooky errors:
```
/s1/l/99x/gradle/generation/extract-jdk-apis/ExtractJdkApis.java:192: error: illegal character: '\ufffd'
public void visitPermittedSubclass???(String c) {
^
```
I think we should do this for 9.9.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] #12911: regenerate binary FSTs for Nori and Kuromoji dictionaries to match current FST format [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand merged PR #12924:
URL: https://github.com/apache/lucene/pull/12924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] #12911: regenerate binary FSTs for Nori and Kuromoji dictionaries to match current FST format [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #12924:
URL: https://github.com/apache/lucene/pull/12924#issuecomment-1852434323
if it regenerates successfully and the test suite passes afterwards (which it seems they do), that's basically it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] #12911: regenerate binary FSTs for Nori and Kuromoji dictionaries to match current FST format [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12924:
URL: https://github.com/apache/lucene/pull/12924#issuecomment-1852434257
Thanks @ChrisHegarty and @dweiss -- I'll merge to 9.9.x, 9.x and main shortly. Hmm, rather, I'll regen on the other two branches (not certain FST format is identical everywhere), and merge this onto 9.9.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] #12911: regenerate binary FSTs for Nori and Kuromoji dictionaries to match current FST format [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12924:
URL: https://github.com/apache/lucene/pull/12924#issuecomment-1852489631
OK I regenerated these two FSTs on 9.9.x, 9.x, and main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org