You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Yang Wang <da...@gmail.com> on 2022/05/31 06:26:02 UTC

[VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Hi everyone,

Please review and vote on the release candidate #3 for the version 1.0.0 of
Apache Flink Kubernetes Operator,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

**Release Overview**

As an overview, the release consists of the following:
a) Kubernetes Operator canonical source distribution (including the
Dockerfile), to be deployed to the release repository at dist.apache.org
b) Kubernetes Operator Helm Chart to be deployed to the release repository
at dist.apache.org
c) Maven artifacts to be deployed to the Maven Central Repository
d) Docker image to be pushed to dockerhub

**Staging Areas to Review**

The staging areas containing the above mentioned artifacts are as follows,
for your review:
* All artifacts for a,b) can be found in the corresponding dev repository
at dist.apache.org [1]
* All artifacts for c) can be found at the Apache Nexus Repository [2]
* The docker image for d) is staged on github [7]

All artifacts are signed with the key
2FF2977BBBFFDF283C6FE7C6A301006F3591EE2C [3]

Other links for your review:
* JIRA release notes [4]
* source code tag "release-1.0.0-rc3" [5]
* PR to update the website Downloads page to include Kubernetes Operator
links [6]

**Vote Duration**

The voting time will run for at least 72 hours.
It is adopted by majority approval, with at least 3 PMC affirmative votes.

**Note on Verification**

You can follow the basic verification guide here[8].
Note that you don't need to verify everything yourself, but please make
note of what you have tested together with your +- vote.

Thanks,
Yang

[1]
https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/
[2] https://repository.apache.org/content/repositories/orgapacheflink-1505/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351500
[5]
https://github.com/apache/flink-kubernetes-operator/tree/release-1.0.0-rc3
[6] https://github.com/apache/flink-web/pull/542
[7] ghcr.io/apache/flink-kubernetes-operator:52b50c2
[8]
https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Yang Wang <da...@gmail.com>.
+1 (binding)

Successfully verified the following:
- Verify that the checksums and GPG files
- Verify that the source distributions do not contain any binaries
- Build binary and image from release source
- Verify the NOTICE and licenses in the docker image
- Verify the helm chart values with correct appVersion and image tag
- Operator functionality manual testing
    - Start a session FlinkDeployment and submit a SessionJob CR
    - Start a Flink Application
    - Verify the FlinkUI could be accessed via ingress
    - The operator logs is normal


Best,
Yang


Nicholas Jiang <ni...@apache.org> 于2022年5月31日周二 16:16写道:

> Hi Yang!
>
> +1 (not-binding)
>
> Verified the following successfully:
>
> - Build from source, build container from source
> - Run the examples for application, session and session job deployments
> successfully and without any errors.
>
> Regards,
> Nicholas Jiang
>
> On 2022/05/31 06:26:02 Yang Wang wrote:
> > Hi everyone,
> >
> > Please review and vote on the release candidate #3 for the version 1.0.0
> of
> > Apache Flink Kubernetes Operator,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > **Release Overview**
> >
> > As an overview, the release consists of the following:
> > a) Kubernetes Operator canonical source distribution (including the
> > Dockerfile), to be deployed to the release repository at dist.apache.org
> > b) Kubernetes Operator Helm Chart to be deployed to the release
> repository
> > at dist.apache.org
> > c) Maven artifacts to be deployed to the Maven Central Repository
> > d) Docker image to be pushed to dockerhub
> >
> > **Staging Areas to Review**
> >
> > The staging areas containing the above mentioned artifacts are as
> follows,
> > for your review:
> > * All artifacts for a,b) can be found in the corresponding dev repository
> > at dist.apache.org [1]
> > * All artifacts for c) can be found at the Apache Nexus Repository [2]
> > * The docker image for d) is staged on github [7]
> >
> > All artifacts are signed with the key
> > 2FF2977BBBFFDF283C6FE7C6A301006F3591EE2C [3]
> >
> > Other links for your review:
> > * JIRA release notes [4]
> > * source code tag "release-1.0.0-rc3" [5]
> > * PR to update the website Downloads page to include Kubernetes Operator
> > links [6]
> >
> > **Vote Duration**
> >
> > The voting time will run for at least 72 hours.
> > It is adopted by majority approval, with at least 3 PMC affirmative
> votes.
> >
> > **Note on Verification**
> >
> > You can follow the basic verification guide here[8].
> > Note that you don't need to verify everything yourself, but please make
> > note of what you have tested together with your +- vote.
> >
> > Thanks,
> > Yang
> >
> > [1]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/
> > [2]
> https://repository.apache.org/content/repositories/orgapacheflink-1505/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351500
> > [5]
> >
> https://github.com/apache/flink-kubernetes-operator/tree/release-1.0.0-rc3
> > [6] https://github.com/apache/flink-web/pull/542
> > [7] ghcr.io/apache/flink-kubernetes-operator:52b50c2
> > [8]
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release
> >
>

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Nicholas Jiang <ni...@apache.org>.
Hi Yang!

+1 (not-binding)

Verified the following successfully:

- Build from source, build container from source
- Run the examples for application, session and session job deployments successfully and without any errors.

Regards,
Nicholas Jiang

On 2022/05/31 06:26:02 Yang Wang wrote:
> Hi everyone,
> 
> Please review and vote on the release candidate #3 for the version 1.0.0 of
> Apache Flink Kubernetes Operator,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> **Release Overview**
> 
> As an overview, the release consists of the following:
> a) Kubernetes Operator canonical source distribution (including the
> Dockerfile), to be deployed to the release repository at dist.apache.org
> b) Kubernetes Operator Helm Chart to be deployed to the release repository
> at dist.apache.org
> c) Maven artifacts to be deployed to the Maven Central Repository
> d) Docker image to be pushed to dockerhub
> 
> **Staging Areas to Review**
> 
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a,b) can be found in the corresponding dev repository
> at dist.apache.org [1]
> * All artifacts for c) can be found at the Apache Nexus Repository [2]
> * The docker image for d) is staged on github [7]
> 
> All artifacts are signed with the key
> 2FF2977BBBFFDF283C6FE7C6A301006F3591EE2C [3]
> 
> Other links for your review:
> * JIRA release notes [4]
> * source code tag "release-1.0.0-rc3" [5]
> * PR to update the website Downloads page to include Kubernetes Operator
> links [6]
> 
> **Vote Duration**
> 
> The voting time will run for at least 72 hours.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
> 
> **Note on Verification**
> 
> You can follow the basic verification guide here[8].
> Note that you don't need to verify everything yourself, but please make
> note of what you have tested together with your +- vote.
> 
> Thanks,
> Yang
> 
> [1]
> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/
> [2] https://repository.apache.org/content/repositories/orgapacheflink-1505/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351500
> [5]
> https://github.com/apache/flink-kubernetes-operator/tree/release-1.0.0-rc3
> [6] https://github.com/apache/flink-web/pull/542
> [7] ghcr.io/apache/flink-kubernetes-operator:52b50c2
> [8]
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release
> 

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Márton Balassi <ba...@gmail.com>.
Thanks, Yang. Looks good after your change. +1 for the 48 hour voting time.


On Wed, Jun 1, 2022 at 7:59 AM Gyula Fóra <gy...@gmail.com> wrote:

> I agree to create a new RC based on this find.
> And 48h voting time seems reasonable as all functional testing will carry
> over to this new candidate.
>
> Gyula
>
> On Wed, Jun 1, 2022 at 7:56 AM Yang Wang <da...@gmail.com> wrote:
>
>> Thanks all for your testing and patience.
>>
>> And sorry for I have to cancel this VOTE since @Márton Balassi
>> <ba...@gmail.com> found a license issue. We do not list the
>> CSS/docs dependencies in the NOTICE file of source release[1].
>>
>> I will create another release candidate today including this fix. Given
>> that there's no functional changes, we could set the voting period to 48
>> hours for next RC.
>>
>>
>> [1].
>>
>> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/
>>
>> Best,
>> Yang
>>
>> Jim Busche <jb...@us.ibm.com> 于2022年6月1日周三 08:30写道:
>>
>> > Hi Yang,  Thank you for RC3
>> >
>> > +1 (not-binding)
>> >
>> >
>> >   *   Podman builds look great with your .dockerignore file and “COPY .
>> > .”  Thank you for the fix.
>> >   *   Twistlock security scans look clean of both your “
>> > ghcr.io/apache/flink-kubernetes-operator:52b50c2 image” as well as a
>> > locally built image from source.
>> >   *   I’ve tried it on both Openshift 4.8 and 4.10 and the basic test
>> and
>> > UI look good, using helm repo install from the provided helm repo as
>> well
>> > as from source with the local image.
>> >   *   Logs look normal
>> >
>> >
>> >
>> > Thank you,
>> >
>> > Jim
>> >
>> >
>> >
>>
>

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Gyula Fóra <gy...@gmail.com>.
I agree to create a new RC based on this find.
And 48h voting time seems reasonable as all functional testing will carry
over to this new candidate.

Gyula

On Wed, Jun 1, 2022 at 7:56 AM Yang Wang <da...@gmail.com> wrote:

> Thanks all for your testing and patience.
>
> And sorry for I have to cancel this VOTE since @Márton Balassi
> <ba...@gmail.com> found a license issue. We do not list the
> CSS/docs dependencies in the NOTICE file of source release[1].
>
> I will create another release candidate today including this fix. Given
> that there's no functional changes, we could set the voting period to 48
> hours for next RC.
>
>
> [1].
>
> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/
>
> Best,
> Yang
>
> Jim Busche <jb...@us.ibm.com> 于2022年6月1日周三 08:30写道:
>
> > Hi Yang,  Thank you for RC3
> >
> > +1 (not-binding)
> >
> >
> >   *   Podman builds look great with your .dockerignore file and “COPY .
> > .”  Thank you for the fix.
> >   *   Twistlock security scans look clean of both your “
> > ghcr.io/apache/flink-kubernetes-operator:52b50c2 image” as well as a
> > locally built image from source.
> >   *   I’ve tried it on both Openshift 4.8 and 4.10 and the basic test and
> > UI look good, using helm repo install from the provided helm repo as well
> > as from source with the local image.
> >   *   Logs look normal
> >
> >
> >
> > Thank you,
> >
> > Jim
> >
> >
> >
>

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Yang Wang <da...@gmail.com>.
Thanks all for your testing and patience.

And sorry for I have to cancel this VOTE since @Márton Balassi
<ba...@gmail.com> found a license issue. We do not list the
CSS/docs dependencies in the NOTICE file of source release[1].

I will create another release candidate today including this fix. Given
that there's no functional changes, we could set the voting period to 48
hours for next RC.


[1].
https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/

Best,
Yang

Jim Busche <jb...@us.ibm.com> 于2022年6月1日周三 08:30写道:

> Hi Yang,  Thank you for RC3
>
> +1 (not-binding)
>
>
>   *   Podman builds look great with your .dockerignore file and “COPY .
> .”  Thank you for the fix.
>   *   Twistlock security scans look clean of both your “
> ghcr.io/apache/flink-kubernetes-operator:52b50c2 image” as well as a
> locally built image from source.
>   *   I’ve tried it on both Openshift 4.8 and 4.10 and the basic test and
> UI look good, using helm repo install from the provided helm repo as well
> as from source with the local image.
>   *   Logs look normal
>
>
>
> Thank you,
>
> Jim
>
>
>

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Jim Busche <jb...@us.ibm.com>.
Hi Yang,  Thank you for RC3

+1 (not-binding)


  *   Podman builds look great with your .dockerignore file and “COPY . .”  Thank you for the fix.
  *   Twistlock security scans look clean of both your “ghcr.io/apache/flink-kubernetes-operator:52b50c2 image” as well as a locally built image from source.
  *   I’ve tried it on both Openshift 4.8 and 4.10 and the basic test and UI look good, using helm repo install from the provided helm repo as well as from source with the local image.
  *   Logs look normal



Thank you,

Jim



Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #3

Posted by Gyula Fóra <gy...@gmail.com>.
Hi Yang!

+1 (binding)

Successfully verified the following:
- Signatures, Hashes
- No binaries in source release
- Helm Repo works, Helm install works, docker image matches release commit
tag
- Build from source, build container from source
- Submit example application, session and session job deployments without
errors

Thank you!
Gyula

On Tue, May 31, 2022 at 8:26 AM Yang Wang <da...@gmail.com> wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #3 for the version 1.0.0 of
> Apache Flink Kubernetes Operator,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> **Release Overview**
>
> As an overview, the release consists of the following:
> a) Kubernetes Operator canonical source distribution (including the
> Dockerfile), to be deployed to the release repository at dist.apache.org
> b) Kubernetes Operator Helm Chart to be deployed to the release repository
> at dist.apache.org
> c) Maven artifacts to be deployed to the Maven Central Repository
> d) Docker image to be pushed to dockerhub
>
> **Staging Areas to Review**
>
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a,b) can be found in the corresponding dev repository
> at dist.apache.org [1]
> * All artifacts for c) can be found at the Apache Nexus Repository [2]
> * The docker image for d) is staged on github [7]
>
> All artifacts are signed with the key
> 2FF2977BBBFFDF283C6FE7C6A301006F3591EE2C [3]
>
> Other links for your review:
> * JIRA release notes [4]
> * source code tag "release-1.0.0-rc3" [5]
> * PR to update the website Downloads page to include Kubernetes Operator
> links [6]
>
> **Vote Duration**
>
> The voting time will run for at least 72 hours.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> **Note on Verification**
>
> You can follow the basic verification guide here[8].
> Note that you don't need to verify everything yourself, but please make
> note of what you have tested together with your +- vote.
>
> Thanks,
> Yang
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/
> [2]
> https://repository.apache.org/content/repositories/orgapacheflink-1505/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351500
> [5]
> https://github.com/apache/flink-kubernetes-operator/tree/release-1.0.0-rc3
> [6] https://github.com/apache/flink-web/pull/542
> [7] ghcr.io/apache/flink-kubernetes-operator:52b50c2
> [8]
>
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release
>