You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/08 18:46:00 UTC

[jira] [Commented] (KAFKA-9386) Flaky test AclAuthorizerTest.testHighConcurrencyDeletionOfResourceAcls

    [ https://issues.apache.org/jira/browse/KAFKA-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010917#comment-17010917 ] 

ASF GitHub Bot commented on KAFKA-9386:
---------------------------------------

rajinisivaram commented on pull request #7911: KAFKA-9386; Apply delete ACL filters to resources from filter even if not in cache
URL: https://github.com/apache/kafka/pull/7911
 
 
   With the old SimpleAclAuthorizer, we were handling delete filters that matched a single resource by looking up that resource directly, even if it wasn't in the cache. AclAuthorizerTest.testHighConcurrencyDeletionOfResourceAcls relies on this behaviour and fails intermittently when the cache is not up-to-date. This PR includes the resource from non-matching filters even if it is not in the cache to retain the old behaviour.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flaky test AclAuthorizerTest.testHighConcurrencyDeletionOfResourceAcls
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-9386
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9386
>             Project: Kafka
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>            Priority: Major
>             Fix For: 2.5.0
>
>
> Failure:
> org.scalatest.exceptions.TestFailedException: expected acls:
>  
> but got:
>  (principal=User:alice, host=*, operation=ALL, permissionType=ALLOW)
> at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:530)
>  at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:529)
>  at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1389)
>  at org.scalatest.Assertions.fail(Assertions.scala:1091)
>  at org.scalatest.Assertions.fail$(Assertions.scala:1087)
>  at org.scalatest.Assertions$.fail(Assertions.scala:1389)
>  at kafka.utils.TestUtils$.waitAndVerifyAcls(TestUtils.scala:843)
>  at kafka.security.authorizer.AclAuthorizerTest.testHighConcurrencyDeletionOfResourceAcls(AclAuthorizerTest.scala:552)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)