You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cuspymd <gi...@git.apache.org> on 2016/12/15 14:13:28 UTC
[GitHub] zeppelin pull request #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('s...
GitHub user cuspymd opened a pull request:
https://github.com/apache/zeppelin/pull/1770
[ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteMenu') calls
### What is this PR for?
It's to fix the issue 'ZEPPELIN-1763' (Zeppelin hangs if I repeatedly select and deselect note name).
When the note name was changed, there was a problem that the 'setNoteName' listener was registered in duplicate and occupied resources.
To fix it, I moved the function that registers the listener out of initNoteBook()
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[ZEPPELIN-1763](https://issues.apache.org/jira/browse/ZEPPELIN-1763?filter=-2)
### How should this be tested?
Repeat changing note name.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
The listners are added in duplicate on $scope.$on('setNoteMenu') calls.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuspymd/zeppelin note-name-pr2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1770
----
commit 99a10314917c2db4a0d88a1efe7780a863d12cee
Author: Myoungdo Park <cu...@gmail.com>
Date: 2016-12-15T13:31:23Z
Prevent duplicate $scope.$on('setNoteMenu') calls
The listners are added in duplicate on $scope.$on('setNoteMenu') calls.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteM...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1770
A test profile failure looks not related. (https://issues.apache.org/jira/browse/ZEPPELIN-1830)
LGTM and merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteM...
Posted by cuspymd <gi...@git.apache.org>.
Github user cuspymd commented on the issue:
https://github.com/apache/zeppelin/pull/1770
@Leemoonsoo Modified
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1770
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteM...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1770
Thanks for the contribution.
I'm getting build error on zeppelin-web module
```
[INFO] Running "jscs:test" (jscs) task
[INFO] disallowMultipleLineBreaks: ; and it should have at most 2 line(s) between them at test/spec/controllers/notebook.js :
[INFO] 100 | scope.killSaveTimer();
[INFO] 101 | expect(scope.saveTimer).toEqual(null);
[INFO] 102 | });
[INFO] -------------^
[INFO] 103 |
[INFO] 104 |
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:test" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```
Could you check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---