You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/16 02:42:14 UTC

[kudu-CR] sasl: add a leak suppression for krb5 1.10 

Hello Dan Burkert, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5101

to review the following change.

Change subject: sasl: add a leak suppression for krb5 1.10
......................................................................

sasl: add a leak suppression for krb5 1.10

This suppresses a known memory leak in krb5 < 1.12 in which a single
error message structure would be leaked in the case that GSSAPI had any
issues acquiring credentials. I bisected this issue against the krb5 git
repository and found the fix is in commit
379d39c17b8930718e98185a5b32a0f7f3e3b4b6 ("Fix a small memory leak in
util_errmap")

I chose to use the suppression file instead of a scoped leak suppression
object since it's still useful to catch any other leaks we might cause
in our use of SASL APIs.

Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
---
M build-support/lsan-suppressions.txt
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5101/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] sasl: add a leak suppression for krb5 1.10

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: sasl: add a leak suppression for krb5 1.10
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] sasl: add a leak suppression for krb5 1.10

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5101

to look at the new patch set (#3).

Change subject: sasl: add a leak suppression for krb5 1.10
......................................................................

sasl: add a leak suppression for krb5 1.10

This suppresses a known memory leak in krb5 < 1.12 in which a single
error message structure would be leaked in the case that GSSAPI had any
issues acquiring credentials. I bisected this issue against the krb5 git
repository and found the fix is in commit
379d39c17b8930718e98185a5b32a0f7f3e3b4b6 ("Fix a small memory leak in
util_errmap")

I chose to use the suppression file instead of a scoped leak suppression
object since it's still useful to catch any other leaks we might cause
in our use of SASL APIs.

Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
---
M build-support/lsan-suppressions.txt
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5101/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] sasl: add a leak suppression for krb5 1.10

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: sasl: add a leak suppression for krb5 1.10
......................................................................


sasl: add a leak suppression for krb5 1.10

This suppresses a known memory leak in krb5 < 1.12 in which a single
error message structure would be leaked in the case that GSSAPI had any
issues acquiring credentials. I bisected this issue against the krb5 git
repository and found the fix is in commit
379d39c17b8930718e98185a5b32a0f7f3e3b4b6 ("Fix a small memory leak in
util_errmap")

I chose to use the suppression file instead of a scoped leak suppression
object since it's still useful to catch any other leaks we might cause
in our use of SASL APIs.

Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
Reviewed-on: http://gerrit.cloudera.org:8080/5101
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/lsan-suppressions.txt
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied53bf43e98fd622026c00226eb38550bbbbdb38
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>