You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 13:36:22 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request, #25096: Upgrade ramaining context file to typescript.
pierrejeambrun opened a new pull request, #25096:
URL: https://github.com/apache/airflow/pull/25096
Upgrade remaining file in `static/js/context/` to typescript.
related: https://github.com/apache/airflow/issues/24350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #25096: Upgrade ramaining context file to typescript.
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #25096:
URL: https://github.com/apache/airflow/pull/25096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #25096: Upgrade ramaining context file to typescript.
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #25096:
URL: https://github.com/apache/airflow/pull/25096#discussion_r922227461
##########
airflow/www/static/js/context/timezone.tsx:
##########
@@ -20,23 +20,25 @@
/* global moment, document */
import React, {
- useContext, useEffect, useState, useMemo,
+ useContext, useEffect, useState, useMemo, ReactNode,
} from 'react';
+
import { TimezoneEvent } from '../datetime_utils';
const TimezoneContext = React.createContext({ timezone: 'UTC' });
-export const TimezoneProvider = ({ children }) => {
+export const TimezoneProvider = ({ children }: { children: ReactNode }) => {
Review Comment:
```suggestion
export const TimezoneProvider = ({ children }: PropsWithChildren) => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #25096: Upgrade ramaining context file to typescript.
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on code in PR #25096:
URL: https://github.com/apache/airflow/pull/25096#discussion_r922236050
##########
airflow/www/static/js/context/timezone.tsx:
##########
@@ -20,23 +20,25 @@
/* global moment, document */
import React, {
- useContext, useEffect, useState, useMemo,
+ useContext, useEffect, useState, useMemo, ReactNode,
} from 'react';
+
import { TimezoneEvent } from '../datetime_utils';
const TimezoneContext = React.createContext({ timezone: 'UTC' });
-export const TimezoneProvider = ({ children }) => {
+export const TimezoneProvider = ({ children }: { children: ReactNode }) => {
Review Comment:
Nice thank you :+1: , updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #25096: Upgrade ramaining context file to typescript.
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on code in PR #25096:
URL: https://github.com/apache/airflow/pull/25096#discussion_r922236050
##########
airflow/www/static/js/context/timezone.tsx:
##########
@@ -20,23 +20,25 @@
/* global moment, document */
import React, {
- useContext, useEffect, useState, useMemo,
+ useContext, useEffect, useState, useMemo, ReactNode,
} from 'react';
+
import { TimezoneEvent } from '../datetime_utils';
const TimezoneContext = React.createContext({ timezone: 'UTC' });
-export const TimezoneProvider = ({ children }) => {
+export const TimezoneProvider = ({ children }: { children: ReactNode }) => {
Review Comment:
Nice thank you :+1, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org