You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 20:38:36 UTC

[GitHub] [camel-website] rimshach opened a new pull request #238: Consistency in title color for blog page

rimshach opened a new pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238
 
 
   I was going through the website and I found the title color different for blog's page as compared to the rest of the website.I think there should be consistency in the entire website so I changed the color
   
   The color for titles or link in other pages:
   
   ![image](https://user-images.githubusercontent.com/44733143/77005099-0f34b980-6982-11ea-8def-d66ddfdf3ffc.png)
   
   The color for blog was :
   ![image](https://user-images.githubusercontent.com/44733143/77005158-2a072e00-6982-11ea-8df0-60f07adefdb2.png)
   
   I have changed it to :
   ![image](https://user-images.githubusercontent.com/44733143/77005269-54f18200-6982-11ea-81a9-b00383223452.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] rimshach commented on a change in pull request #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
rimshach commented on a change in pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#discussion_r397193158
 
 

 ##########
 File path: antora-ui-camel/src/css/doc.css
 ##########
 @@ -116,7 +116,7 @@
 }
 
 .doc a {
-  color: var(--link-font-color);
+  color: #303284;
 
 Review comment:
   oh okay, there is an option under each heading link of "continue reading " ,that link and heading link redirects us to the same page, so would it be okay to remove the link from the heading ? 
   Or as in the home page the link "What's New?" has been assigned color of a regular heading 
   ![image](https://user-images.githubusercontent.com/44733143/77436049-d32ba980-6e04-11ea-8066-3cf45ef7e165.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#issuecomment-604382589
 
 
   @rimshach I think it makes sense to remove the heading link from the blog post list as we already have the "continue reading" link there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] rimshach commented on issue #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
rimshach commented on issue #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#issuecomment-603274960
 
 
   oh alright.I actually looked at the heading link of "what's new " at home page that was consistent with rest of the headings so I thought overall headings can have same color.
   For this page  there is an option under each heading link of "continue reading " ,that link and heading link redirects us to the same page, so would it be okay to remove the link from the heading ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] rimshach commented on a change in pull request #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
rimshach commented on a change in pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#discussion_r397193158
 
 

 ##########
 File path: antora-ui-camel/src/css/doc.css
 ##########
 @@ -116,7 +116,7 @@
 }
 
 .doc a {
-  color: var(--link-font-color);
+  color: #303284;
 
 Review comment:
   oh alright.I actually looked at the heading link of "what's new " at home page that was consistent with rest of the headings so I thought overall headings can have same color.
   For this page  there is an option under each heading link of "continue reading " ,that link and heading link redirects us to the same page, so would it be okay to remove the link from the heading ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] rimshach closed pull request #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
rimshach closed pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] rimshach commented on a change in pull request #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
rimshach commented on a change in pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#discussion_r397193158
 
 

 ##########
 File path: antora-ui-camel/src/css/doc.css
 ##########
 @@ -116,7 +116,7 @@
 }
 
 .doc a {
-  color: var(--link-font-color);
+  color: #303284;
 
 Review comment:
   oh alright.I actually looked at the heading link of "what's new " at home page that was consistent with rest of the headings so I thought overall headings can have same color.
   For this page  there is an option under each heading link of "continue reading " ,that link and heading link redirects us to the same page, so would it be okay to remove the link from the heading ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] rimshach commented on a change in pull request #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
rimshach commented on a change in pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#discussion_r397200964
 
 

 ##########
 File path: antora-ui-camel/src/css/doc.css
 ##########
 @@ -116,7 +116,7 @@
 }
 
 .doc a {
-  color: var(--link-font-color);
+  color: #303284;
 
 Review comment:
   Oh , I'll consider this before making any further changes 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #238: Consistency in title color for blog page

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #238: Consistency in title color for blog page
URL: https://github.com/apache/camel-website/pull/238#discussion_r397079875
 
 

 ##########
 File path: antora-ui-camel/src/css/doc.css
 ##########
 @@ -116,7 +116,7 @@
 }
 
 .doc a {
-  color: var(--link-font-color);
+  color: #303284;
 
 Review comment:
   We use CSS variables, it's very difficult to maintain individual values scattered across CSS files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services