You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gerolf Seitz (JIRA)" <ji...@apache.org> on 2007/10/06 00:14:50 UTC

[jira] Resolved: (WICKET-1046) FeedbackMessages don't get cleaned up in an AJAX request when renderstrategy is REDIRECT_TO_RENDER

     [ https://issues.apache.org/jira/browse/WICKET-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz resolved WICKET-1046.
----------------------------------

    Resolution: Fixed

> FeedbackMessages don't get cleaned up in an AJAX request when renderstrategy is REDIRECT_TO_RENDER
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1046
>                 URL: https://issues.apache.org/jira/browse/WICKET-1046
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Gerolf Seitz
>            Assignee: Gerolf Seitz
>             Fix For: 1.3.0-beta4
>
>
> the following check in Session#cleanupFeedbackMessages always fails for AjaxRequests when the renderstrategy REDIRECT_TO_RENDER is used.
> this leads to FeedbackMessages not being removed from the session.
> if (Application.get().getRequestCycleSettings().getRenderStrategy() != IRequestCycleSettings.REDIRECT_TO_RENDER || (!RequestCycle.get().isRedirect()))
> RequestCycle.get().isRedirect()  in case of a WebRequestCycle returns true for Ajax requests.
> fix:
> mark Session#cleanupFeedbackMessages as abstract and implement it in WebSession with an additional check "|| ((WebRequest)RequestCycle.get().getResponse).isAjax()"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.